add a red/green fixture test for every shipped rule

Each of the 13 rules gets a fixture built to violate it and one built to satisfy
it, asserted on the violation count and message rather than on the rule having
run. The library had no such test, which is why rules that match nothing have
been reporting success.

This commit is deliberately red: nine tests fail. Eight fixtures that must
produce a violation do not.

  - test classes with no production counterpart (rule is fully dead)
  - a blacklisted annotation on a constructor parameter
  - a blacklisted method call from a constructor
  - a blacklisted method call from an instance field initializer
  - System.out from a constructor
  - a @nested test class whose production class is missing entirely
  - a controller method covered only by a longer-named sibling's @nested class
  - a non-static SortMappings field

The ninth is not a fixture: the blacklist names three AssertJ methods that do not
exist, so those entries can never match.

Fixtures live outside it.aboutbits.archunit.toolbox so the project's own
ArchitectureTest does not analyse them, and are excluded from surefire because
some are named *Test.

Third-party types the blacklists name are stubbed rather than depended on:
spring-boot-toolbox depends on archunit-toolbox, so SortMappings, @Store and
@ArchAllowDirectAccess cannot come from there. The stub contracts were verified
against the real 2.5.2 artifact.

Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>

Author: SirCotare

pom.xml

@@ -50,6 +50,32 @@
             <version>1.4.2</version>
             <scope>compile</scope>
         </dependency>
+
+        <!-- Test only: needed to run this library's own rule tests -->
+        <dependency>
+            <groupId>org.junit.jupiter</groupId>
+            <artifactId>junit-jupiter-engine</artifactId>
+            <scope>test</scope>
+        </dependency>
+        <dependency>
+            <groupId>org.assertj</groupId>
+            <artifactId>assertj-core</artifactId>
+            <scope>test</scope>
+        </dependency>
+        <!--
+            Fixtures for the two rules in CommonArchRuleCollection need real Spring MVC annotations.
+            Test scope only, so consumers do not inherit them.
+        -->
+        <dependency>
+            <groupId>org.springframework</groupId>
+            <artifactId>spring-web</artifactId>
+            <scope>test</scope>
+        </dependency>
+        <dependency>
+            <groupId>org.springframework</groupId>
+            <artifactId>spring-context</artifactId>
+            <scope>test</scope>
+        </dependency>
     </dependencies>
 
     <build>
@@ -98,6 +124,20 @@
                     <fork>true</fork>
                 </configuration>
             </plugin>
+            <plugin>
+                <groupId>org.apache.maven.plugins</groupId>
+                <artifactId>maven-surefire-plugin</artifactId>
+                <configuration>
+                    <!--
+                        it.aboutbits.archunit.fixture contains deliberately non-conforming classes that
+                        the rule tests import as input. Some are named *Test and would otherwise be
+                        collected and reported as tests of this project.
+                    -->
+                    <excludes>
+                        <exclude>it/aboutbits/archunit/fixture/**</exclude>
+                    </excludes>
+                </configuration>
+            </plugin>
             <plugin>
                 <groupId>org.apache.maven.plugins</groupId>
                 <artifactId>maven-checkstyle-plugin</artifactId>

src/test/java/it/aboutbits/archunit/fixture/barren/PlainClass.java

@@ -0,0 +1,14 @@
+package it.aboutbits.archunit.fixture.barren;
+
+import org.jspecify.annotations.NullMarked;
+
+/**
+ * A codebase with no test classes, no records, no controllers and no stores. Used to pin that a rule
+ * whose selection comes up empty fails instead of reporting success.
+ */
+@NullMarked
+public class PlainClass {
+    public String value() {
+        return "value";
+    }
+}

src/test/java/it/aboutbits/archunit/fixture/blacklistannotations/badclass/AnnotatedClass.java

@@ -0,0 +1,5 @@
+package it.aboutbits.archunit.fixture.blacklistannotations.badclass;
+
+@org.junit.Ignore
+public class AnnotatedClass {
+}

src/test/java/it/aboutbits/archunit/fixture/blacklistannotations/badctorparam/AnnotatedConstructorParameter.java

@@ -0,0 +1,14 @@
+package it.aboutbits.archunit.fixture.blacklistannotations.badctorparam;
+
+/** The canonical Lombok position, and the one a rule iterating only getMethods() cannot see. */
+public class AnnotatedConstructorParameter {
+    private final String value;
+
+    public AnnotatedConstructorParameter(@lombok.NonNull String value) {
+        this.value = value;
+    }
+
+    public String value() {
+        return value;
+    }
+}

src/test/java/it/aboutbits/archunit/fixture/blacklistannotations/badfield/AnnotatedField.java

@@ -0,0 +1,10 @@
+package it.aboutbits.archunit.fixture.blacklistannotations.badfield;
+
+public class AnnotatedField {
+    @lombok.NonNull
+    private String value = "x";
+
+    public String value() {
+        return value;
+    }
+}

src/test/java/it/aboutbits/archunit/fixture/blacklistannotations/badmethod/AnnotatedMethod.java

@@ -0,0 +1,7 @@
+package it.aboutbits.archunit.fixture.blacklistannotations.badmethod;
+
+public class AnnotatedMethod {
+    @org.junit.Ignore
+    public void doWork() {
+    }
+}

src/test/java/it/aboutbits/archunit/fixture/blacklistannotations/badparam/AnnotatedParameter.java

@@ -0,0 +1,7 @@
+package it.aboutbits.archunit.fixture.blacklistannotations.badparam;
+
+public class AnnotatedParameter {
+    public void doWork(@lombok.NonNull String value) {
+        System.identityHashCode(value);
+    }
+}

src/test/java/it/aboutbits/archunit/fixture/blacklistannotations/good/CleanClass.java

@@ -0,0 +1,13 @@
+package it.aboutbits.archunit.fixture.blacklistannotations.good;
+
+public class CleanClass {
+    private String value = "x";
+
+    public void doWork(String input) {
+        this.value = input;
+    }
+
+    public String value() {
+        return value;
+    }
+}

src/test/java/it/aboutbits/archunit/fixture/blacklistclasses/bad/UsesFaker.java

@@ -0,0 +1,9 @@
+package it.aboutbits.archunit.fixture.blacklistclasses.bad;
+
+import net.datafaker.Faker;
+
+public class UsesFaker {
+    public String randomName() {
+        return new Faker().name();
+    }
+}

src/test/java/it/aboutbits/archunit/fixture/blacklistclasses/good/UsesNothingBlacklisted.java

@@ -0,0 +1,7 @@
+package it.aboutbits.archunit.fixture.blacklistclasses.good;
+
+public class UsesNothingBlacklisted {
+    public String randomName() {
+        return "fixed";
+    }
+}