From 9a06263254b76f12771df1e4b8eed8274deac006 Mon Sep 17 00:00:00 2001 From: Lukas Weiss Date: Tue, 18 Jun 2024 07:27:01 +0200 Subject: [PATCH 1/2] improve import-order to be unambiguous by defining all groups --- ts.js | 25 +++++++++++++++++++++---- 1 file changed, 21 insertions(+), 4 deletions(-) diff --git a/ts.js b/ts.js index 9094157..dfb5b51 100644 --- a/ts.js +++ b/ts.js @@ -1,7 +1,6 @@ module.exports = { extends: [ 'eslint:recommended', - 'plugin:@typescript-eslint/strict-type-checked', 'plugin:import/recommended', 'plugin:import/typescript', 'plugin:prettier/recommended' @@ -27,7 +26,8 @@ module.exports = { overrides: [ { extends: [ - 'plugin:@typescript-eslint/recommended-requiring-type-checking' + 'plugin:@typescript-eslint/strict-type-checked', + 'plugin:@typescript-eslint/stylistic-type-checked', ], files: ['./**/*.{ts,tsx}'] } @@ -47,8 +47,25 @@ module.exports = { 'import/order': [ 'error', { - groups: ['builtin', 'external', 'unknown', 'parent', 'sibling', 'index'] - } + groups: [ + 'builtin', + 'external', + 'internal', + 'unknown', + 'parent', + 'sibling', + 'index', + 'object', + 'type', + ], + alphabetize: { + order: 'asc', + orderImportKind: 'asc', + caseInsensitive: true, + }, + 'newlines-between': 'never', + warnOnUnassignedImports: true, + }, ], 'no-console': [ 'error', From 59212d471868c274c3a51b9ede4cc4bc2a93f2fc Mon Sep 17 00:00:00 2001 From: Lukas Weiss Date: Tue, 18 Jun 2024 08:28:38 +0200 Subject: [PATCH 2/2] revert unintended eslint plugin change --- ts.js | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/ts.js b/ts.js index dfb5b51..a5051c8 100644 --- a/ts.js +++ b/ts.js @@ -1,6 +1,7 @@ module.exports = { extends: [ 'eslint:recommended', + 'plugin:@typescript-eslint/strict-type-checked', 'plugin:import/recommended', 'plugin:import/typescript', 'plugin:prettier/recommended' @@ -26,8 +27,7 @@ module.exports = { overrides: [ { extends: [ - 'plugin:@typescript-eslint/strict-type-checked', - 'plugin:@typescript-eslint/stylistic-type-checked', + 'plugin:@typescript-eslint/recommended-requiring-type-checking' ], files: ['./**/*.{ts,tsx}'] }