Skip to content

Commit 1247f98

Browse files
authored
align s3 preview root folder naming with postgres (#11)
1 parent 671df21 commit 1247f98

4 files changed

Lines changed: 11 additions & 11 deletions

File tree

setup-s3-preview/action.yml

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -52,27 +52,27 @@ runs:
5252
JOB_NAME: "prepare-s3-preview-${{ inputs.preview-number }}"
5353
CONFIGMAP_NAME: "${{ inputs.configmap-name }}"
5454
SECRET_NAME: "${{ inputs.secret-name }}"
55+
PREVIEW_ROOT_FOLDER: "preview_${{ inputs.preview-number }}"
5556
S3_BUCKET_KEY: "${{ inputs.s3-bucket-key }}"
5657
S3_ENDPOINT_KEY: "${{ inputs.s3-endpoint-key }}"
5758
S3_REGION_KEY: "${{ inputs.s3-region-key }}"
5859
S3_ROOT_FOLDER_KEY: "${{ inputs.s3-root-folder-key }}"
5960
S3_FORCE_PATH_STYLE_ACCESS_KEY: "${{ inputs.s3-force-path-style-access-key }}"
6061
S3_ACCESS_KEY_KEY: "${{ inputs.s3-access-key-key }}"
6162
S3_SECRET_KEY_KEY: "${{ inputs.s3-secret-key-key }}"
62-
PREVIEW_NUMBER: "${{ inputs.preview-number }}"
6363
run: |
6464
envsubst '
6565
$JOB_NAME
6666
$CONFIGMAP_NAME
6767
$SECRET_NAME
68+
$PREVIEW_ROOT_FOLDER
6869
$S3_BUCKET_KEY
6970
$S3_ENDPOINT_KEY
7071
$S3_REGION_KEY
7172
$S3_ROOT_FOLDER_KEY
7273
$S3_FORCE_PATH_STYLE_ACCESS_KEY
7374
$S3_ACCESS_KEY_KEY
7475
$S3_SECRET_KEY_KEY
75-
$PREVIEW_NUMBER
7676
' < ${{ github.action_path }}/job-template.yml > job-setup-s3.yml
7777
7878
echo "Prepared job manifest: job-setup-s3.yml"

setup-s3-preview/job-template.yml

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -36,8 +36,8 @@ spec:
3636
S3_SOURCE_PREFIX="s3://$S3_BUCKET/"
3737
fi
3838
39-
S3_PREVIEW_PREFIX="s3://$S3_BUCKET/preview-${PREVIEW_NUMBER}/"
40-
39+
S3_PREVIEW_PREFIX="s3://$S3_BUCKET/${PREVIEW_ROOT_FOLDER}/"
40+
4141
echo "Checking if $S3_PREVIEW_PREFIX already exists..."
4242
if [ "$(aws s3 $S3_ARGS ls "$S3_PREVIEW_PREFIX" | wc -l)" -gt 0 ]; then
4343
echo "$S3_PREVIEW_PREFIX already exists. Skipping setup."
@@ -90,5 +90,5 @@ spec:
9090
secretKeyRef:
9191
name: ${SECRET_NAME}
9292
key: ${S3_SECRET_KEY_KEY}
93-
- name: PREVIEW_NUMBER
94-
value: "${PREVIEW_NUMBER}"
93+
- name: PREVIEW_ROOT_FOLDER
94+
value: "${PREVIEW_ROOT_FOLDER}"

teardown-s3-preview/action.yml

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -48,25 +48,25 @@ runs:
4848
JOB_NAME: "teardown-s3-preview-${{ inputs.preview-number }}"
4949
CONFIGMAP_NAME: "${{ inputs.configmap-name }}"
5050
SECRET_NAME: "${{ inputs.secret-name }}"
51+
PREVIEW_ROOT_FOLDER: "preview_${{ inputs.preview-number }}"
5152
S3_BUCKET_KEY: "${{ inputs.s3-bucket-key }}"
5253
S3_ENDPOINT_KEY: "${{ inputs.s3-endpoint-key }}"
5354
S3_REGION_KEY: "${{ inputs.s3-region-key }}"
5455
S3_FORCE_PATH_STYLE_ACCESS_KEY: "${{ inputs.s3-force-path-style-access-key }}"
5556
S3_ACCESS_KEY_KEY: "${{ inputs.s3-access-key-key }}"
5657
S3_SECRET_KEY_KEY: "${{ inputs.s3-secret-key-key }}"
57-
PREVIEW_NUMBER: "${{ inputs.preview-number }}"
5858
run: |
5959
envsubst '
6060
$JOB_NAME
6161
$CONFIGMAP_NAME
6262
$SECRET_NAME
63+
$PREVIEW_ROOT_FOLDER
6364
$S3_BUCKET_KEY
6465
$S3_ENDPOINT_KEY
6566
$S3_REGION_KEY
6667
$S3_FORCE_PATH_STYLE_ACCESS_KEY
6768
$S3_ACCESS_KEY_KEY
6869
$S3_SECRET_KEY_KEY
69-
$PREVIEW_NUMBER
7070
' < ${{ github.action_path }}/job-template.yml > job-teardown-s3.yml
7171
7272
echo "Prepared job manifest: job-teardown-s3.yml"

teardown-s3-preview/job-template.yml

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -29,7 +29,7 @@ spec:
2929
S3_ARGS="--endpoint-url $S3_ENDPOINT"
3030
fi
3131
32-
S3_PREVIEW_PREFIX="s3://$S3_BUCKET/preview-${PREVIEW_NUMBER}/"
32+
S3_PREVIEW_PREFIX="s3://$S3_BUCKET/${PREVIEW_ROOT_FOLDER}/"
3333
3434
echo "Checking if $S3_PREVIEW_PREFIX exists..."
3535
if [ "$(aws s3 $S3_ARGS ls "$S3_PREVIEW_PREFIX" | wc -l)" -eq 0 ]; then
@@ -77,5 +77,5 @@ spec:
7777
secretKeyRef:
7878
name: ${SECRET_NAME}
7979
key: ${S3_SECRET_KEY_KEY}
80-
- name: PREVIEW_NUMBER
81-
value: "${PREVIEW_NUMBER}"
80+
- name: PREVIEW_ROOT_FOLDER
81+
value: "${PREVIEW_ROOT_FOLDER}"

0 commit comments

Comments
 (0)