Skip to content

GitHub action to setup Helm chart with appVersion for deployment - #3

Merged
stplasim merged 6 commits into
mainfrom
ab-353-github-action-to-setup-helm-chart-with-appversion-for
Mar 5, 2025
Merged

GitHub action to setup Helm chart with appVersion for deployment#3
stplasim merged 6 commits into
mainfrom
ab-353-github-action-to-setup-helm-chart-with-appversion-for

Conversation

@stplasim

Copy link
Copy Markdown
Contributor

No description provided.

@stplasim
stplasim requested a review from alexlanz February 28, 2025 15:12

@alexlanz alexlanz left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice job!

Comment thread do-setup-kubectl/action.yml Outdated
Comment thread helm-deploy/action.yml Outdated
Comment thread helm-deploy/action.yml Outdated
Comment thread helm-deploy/action.yml
Comment on lines +56 to +60
- name: Extract Helm chart
shell: bash
working-directory: ${{ inputs.working-directory }}
run: |
tar -xzf ${{ inputs.helm-package }}-*.tgz

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oh wow, is this really a required step. 🤯

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We only need this step because we want to set the app version to the commit hash. If we didn't set this or left it at a fixed value, we could omit this and the pull step and specify the OCI image directly when upgrading. But as I said, without the app version it is relatively difficult to find the deployment again

stplasim and others added 3 commits March 3, 2025 08:52
Co-authored-by: Alex Lanz <alex.lanz@aboutbits.it>
…lm-chart-with-appversion-for' into ab-353-github-action-to-setup-helm-chart-with-appversion-for
@stplasim
stplasim merged commit 495d191 into main Mar 5, 2025
@stplasim
stplasim deleted the ab-353-github-action-to-setup-helm-chart-with-appversion-for branch March 5, 2025 10:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants