fix typos and some other issues

Author: ThoSap

.editorconfig

@@ -10,7 +10,7 @@ max_line_length = 120
 tab_width = 4
 ij_continuation_indent_size = 8
 
-[*.yml]
+[{*.yml,*.yaml}]
 indent_size = 2
 
 [*.md]

build.gradle.kts

@@ -70,6 +70,7 @@ subprojects {
         options.errorprone {
             check("NullAway", CheckSeverity.ERROR)
             option("NullAway:AnnotatedPackages", "it.aboutbits.postgresql")
+            option("NullAway:JSpecifyMode", "true")
         }
     }
 

operator/build.gradle.kts

@@ -1,6 +1,3 @@
-import net.ltgt.gradle.errorprone.CheckSeverity
-import net.ltgt.gradle.errorprone.errorprone
-
 plugins {
     id("io.quarkus")
 }
@@ -67,16 +64,6 @@ dependencies {
     testImplementation(libs.datafaker)
 }
 
-tasks.withType<JavaCompile> {
-    options.encoding = "UTF-8"
-    options.compilerArgs.add("-parameters")
-
-    options.errorprone {
-        check("NullAway", CheckSeverity.ERROR)
-        option("NullAway:AnnotatedPackages", "it.aboutbits.postgresql")
-    }
-}
-
 tasks.quarkusDev {
     // Java 24+ issue. Remove after this has been fixed.
     // https://github.com/quarkusio/quarkus/issues/47769#issuecomment-3148789105

operator/src/main/java/it/aboutbits/postgresql/crd/grant/GrantReconciler.java

@@ -277,7 +277,7 @@ private UpdateControl<Grant> reconcileInTransaction(
             }
 
             // If we are not in the "ALL" mode, e.g. objects is an empty List, do explicit grants
-            // We need to exclude objectType's DATABASE and SCHEMA as the CRD doesn't alllow to specify objects there
+            // We need to exclude objectType's DATABASE and SCHEMA as the CRD doesn't allow to specify objects there
             if (!isAllMode
                     || objectType == GrantObjectType.DATABASE
                     || objectType == GrantObjectType.SCHEMA

operator/src/main/java/it/aboutbits/postgresql/crd/grant/GrantService.java

@@ -40,7 +40,7 @@ public class GrantService {
     // language=SQL
     private static final String NAMESPACE_OID_SQL = "{0}::regnamespace";
 
-    /// Determines all existing privileges for the specified `role`, when applicable `schema`, and the given `objectTyoe`.
+    /// Determines all existing privileges for the specified `role`, when applicable `schema`, and the given `objectType`.
     ///
     /// @param tx   The DSLContext for database operations.
     /// @param spec The GrantSpec containing the specification details.

operator/src/main/java/it/aboutbits/postgresql/crd/grant/GrantSpec.java

@@ -109,7 +109,7 @@ public class GrantSpec {
     @JsonFormat(with = JsonFormat.Feature.ACCEPT_CASE_INSENSITIVE_VALUES)
     @ValidationRule(
             value = "self.size() > 0",
-            message = "The Grant privileges must not be empty. The operator currently does not support revoking all privileges from existing roles (e.g. public user) by specifying an empty array."
+            message = "The Grant privileges must not be empty. The Operator currently does not support revoking all privileges from existing roles (e.g. public user) by specifying an empty array."
     )
     private List<GrantPrivilege> privileges = new ArrayList<>();
 }

operator/src/test/java/it/aboutbits/postgresql/_support/testdata/persisted/creator/GrantCreate.java

@@ -132,7 +132,7 @@ protected Grant create(int index) {
             spec.setSchema(getSchema());
         }
 
-        if ((withObjectType != GrantObjectType.DATABASE && withObjectType == GrantObjectType.SCHEMA)
+        if ((withObjectType != GrantObjectType.DATABASE && withObjectType != GrantObjectType.SCHEMA)
                 || withObjects != null
         ) {
             spec.setObjects(withObjects);

operator/src/test/java/it/aboutbits/postgresql/crd/grant/GrantReconcilerTest.java

@@ -132,6 +132,7 @@ void failWhenRoleIsBlankOrEmptyString(
                         .hasMessageContaining("The Grant role must not be empty.");
             }
 
+            @ParameterizedTest
             @BlankSource
             @DisplayName("Should fail when the schema is a blank or empty String (CEL rule)")
             void failWhenSchemaIsBlankOrEmptyString(
@@ -151,7 +152,7 @@ void failWhenSchemaIsBlankOrEmptyString(
             }
 
             @Test
-            @DisplayName("Should fail when the privileges are a empty List (CEL rule)")
+            @DisplayName("Should fail when the privileges are an empty List (CEL rule)")
             void failWhenPrivilegesAreAnEmptyList(
             ) {
                 // then
@@ -297,7 +298,7 @@ void failWhenDatabaseHasObjects() {
             }
 
             @Test
-            @DisplayName("Should fail when objectType is DATABASE but objects has items (CEL rule)")
+            @DisplayName("Should fail when objectType is SCHEMA but objects has items (CEL rule)")
             void failWhenSchemaHasObjects() {
                 // then
                 assertThatThrownBy(() ->
@@ -603,7 +604,7 @@ void grantOnAllTables() {
                     Set.of(SELECT)
             );
             assertThatPrivileges(
-                    clusterConnectionMain,
+                    clusterConnectionDb,
                     grant,
                     tableName2,
                     Set.of(SELECT)