add other CEL validations

Author: ThoSap

README.md

@@ -93,7 +93,7 @@ users:
 
 ### 2. Create PostgreSQL Connection and Secret
 
-For the `postgresql` Dev Service, you can generate the necessary Custom Resources to test the operator:
+For the `postgresql` Dev Service, you can generate the necessary Custom Resources to test the Operator:
 
 1.  From the Dev UI, get the `postgresql` Dev Service properties (username, password, host, port).
 2.  Convert the `postgresql` Dev Service properties to a **Basic Auth Secret** and a **ClusterConnection** CR instance.

operator/src/main/java/it/aboutbits/postgresql/core/ClusterReference.java

@@ -1,6 +1,7 @@
 package it.aboutbits.postgresql.core;
 
 import io.fabric8.generator.annotation.Required;
+import io.fabric8.generator.annotation.ValidationRule;
 import lombok.Getter;
 import lombok.Setter;
 import org.jspecify.annotations.NullMarked;
@@ -11,6 +12,10 @@
 @Setter
 public class ClusterReference {
     @Required
+    @ValidationRule(
+            value = "self.size() > 0",
+            message = "The ClusterReference name must not be empty."
+    )
     private String name = "";
 
     @Nullable

operator/src/main/java/it/aboutbits/postgresql/core/SecretRef.java

@@ -1,6 +1,7 @@
 package it.aboutbits.postgresql.core;
 
 import io.fabric8.generator.annotation.Required;
+import io.fabric8.generator.annotation.ValidationRule;
 import lombok.Getter;
 import lombok.Setter;
 import org.jspecify.annotations.NullMarked;
@@ -11,6 +12,10 @@
 @Setter
 public class SecretRef {
     @Required
+    @ValidationRule(
+            value = "self.size() > 0",
+            message = "The SecretRef name must not be empty."
+    )
     private String name = "";
 
     /**

operator/src/main/java/it/aboutbits/postgresql/crd/clusterconnection/ClusterConnectionSpec.java

@@ -1,6 +1,9 @@
 package it.aboutbits.postgresql.crd.clusterconnection;
 
+import io.fabric8.generator.annotation.Max;
+import io.fabric8.generator.annotation.Min;
 import io.fabric8.generator.annotation.Required;
+import io.fabric8.generator.annotation.ValidationRule;
 import it.aboutbits.postgresql.core.SecretRef;
 import lombok.Getter;
 import lombok.Setter;
@@ -14,12 +17,22 @@
 @Setter
 public class ClusterConnectionSpec {
     @Required
+    @ValidationRule(
+            value = "self.size() > 0",
+            message = "The ClusterConnection host must not be empty."
+    )
     private String host = "";
 
     @Required
-    private Integer port = -1;
+    @Min(1)
+    @Max(65535)
+    private int port = -1;
 
     @Required
+    @ValidationRule(
+            value = "self.size() > 0",
+            message = "The ClusterConnection maintenanceDatabase must not be empty."
+    )
     private String maintenanceDatabase = "postgres";
 
     @Required

operator/src/main/java/it/aboutbits/postgresql/crd/grant/GrantSpec.java

@@ -14,6 +14,10 @@
 @NullMarked
 @Getter
 @Setter
+@ValidationRule(
+        value = "self.objectType == 'database' || (has(self.schema) && self.schema.size() > 0)",
+        message = "The Grant schema is required to be set, except if objectType is 'database'."
+)
 public class GrantSpec {
     @Required
     private ClusterReference clusterRef = new ClusterReference();
@@ -24,6 +28,10 @@ public class GrantSpec {
             value = "self == oldSelf",
             message = "The Grant database is immutable. Changing it would require revoking permissions from the old database before granting them in the new one."
     )
+    @ValidationRule(
+            value = "self.size() > 0",
+            message = "The Grant database must not be empty."
+    )
     private String database = "";
 
     /// The name of the role to grant privileges on.
@@ -32,14 +40,21 @@ public class GrantSpec {
             value = "self == oldSelf",
             message = "The Grant role is immutable. Changing it would require revoking permissions from the old role before granting them to the new one."
     )
+    @ValidationRule(
+            value = "self.size() > 0",
+            message = "The Grant role must not be empty."
+    )
     private String role = "";
 
     /// The database schema to grant privileges on for this role (required except if objectType is "database")
-    @Required
     @ValidationRule(
             value = "self == oldSelf",
             message = "The Grant schema is immutable. Changing it would require revoking permissions from the old schema before granting them to objects in the new schema."
     )
+    @ValidationRule(
+            value = "self.size() > 0",
+            message = "The Grant schema must not be empty."
+    )
     private String schema = "";
 
     /// The PostgreSQL object type to grant the privileges on.
@@ -72,7 +87,7 @@ public class GrantSpec {
     private List<String> objects = new ArrayList<>();
 
     /// The privileges to grant on the PostgreSQL objects.
-    /// The operator also validates if the objectType supports the privileges.
+    /// The Operator also validates if the objectType supports the privileges.
     ///
     /// There are different kinds of privileges:
     /// - `select`

operator/src/main/java/it/aboutbits/postgresql/crd/role/RoleSpec.java

@@ -21,7 +21,11 @@ public class RoleSpec {
     @Required
     @ValidationRule(
             value = "self == oldSelf",
-            message = "The Role name is immutable. Allowing to rename the Role name using 'alter role <old_name> rename to <new_name>' would add unwanted side-effects to the operator."
+            message = "The Role name is immutable. Allowing to rename the Role name using 'alter role <old_name> rename to <new_name>' would add unwanted side-effects to the Operator."
+    )
+    @ValidationRule(
+            value = "self.size() > 0",
+            message = "The Role name must not be empty."
     )
     private String name = "";