From 2d2dfbd18e14c484a162e4bff7eaf2f442eebe18 Mon Sep 17 00:00:00 2001 From: Alex Lanz Date: Wed, 9 Aug 2023 09:07:50 +0200 Subject: [PATCH 1/2] ignore certain icons --- generator.js | 4 ++++ src/IconAddChartOutlined.tsx | 14 +++++++++++--- src/IconAddChartRounded.tsx | 14 +++++++++++--- src/IconAddChartSharp.tsx | 15 +++++++++++---- src/IconAddChartTwoTone.tsx | 14 +++++++++++--- src/IconAddchart.tsx | 8 ++++---- 6 files changed, 52 insertions(+), 17 deletions(-) diff --git a/generator.js b/generator.js index 7b1aaf6e3..6625438d8 100644 --- a/generator.js +++ b/generator.js @@ -11,6 +11,8 @@ const ICON_FAMILIES = [ { id: 'materialiconstwotone', postfix: 'TwoTone' }, ] +const ignoredIcons = ['addchart'] + ;(async () => { generatePropsFile() @@ -21,6 +23,8 @@ const ICON_FAMILIES = [ const icons = await JSON.parse(data) for (let i = 0; i < icons.icons.length; i++) { + if (ignoredIcons.includes(icons.icons[i].name)) continue + generateComponentsForAllFamilies(icons.icons[i]) } })() diff --git a/src/IconAddChartOutlined.tsx b/src/IconAddChartOutlined.tsx index 27595c194..0bbc28d8a 100644 --- a/src/IconAddChartOutlined.tsx +++ b/src/IconAddChartOutlined.tsx @@ -1,7 +1,7 @@ import React from 'react' import { IconProps } from './types' -const IconAddchartOutlined: React.FC = ({ ...props }) => ( +const IconAddChartOutlined: React.FC = ({ ...props }) => ( = ({ ...props }) => ( {props.title && {props.title}} - + + + + + + + + + ) -export { IconAddchartOutlined as default } +export { IconAddChartOutlined as default } diff --git a/src/IconAddChartRounded.tsx b/src/IconAddChartRounded.tsx index c6a295fd5..363008aec 100644 --- a/src/IconAddChartRounded.tsx +++ b/src/IconAddChartRounded.tsx @@ -1,7 +1,7 @@ import React from 'react' import { IconProps } from './types' -const IconAddchartRounded: React.FC = ({ ...props }) => ( +const IconAddChartRounded: React.FC = ({ ...props }) => ( = ({ ...props }) => ( {props.title && {props.title}} - + + + + + + + + + ) -export { IconAddchartRounded as default } +export { IconAddChartRounded as default } diff --git a/src/IconAddChartSharp.tsx b/src/IconAddChartSharp.tsx index c7a6d1b0d..dd0c45879 100644 --- a/src/IconAddChartSharp.tsx +++ b/src/IconAddChartSharp.tsx @@ -1,7 +1,7 @@ import React from 'react' import { IconProps } from './types' -const IconAddchartSharp: React.FC = ({ ...props }) => ( +const IconAddChartSharp: React.FC = ({ ...props }) => ( = ({ ...props }) => ( {props.title && {props.title}} - - + + + + + + + + + ) -export { IconAddchartSharp as default } +export { IconAddChartSharp as default } diff --git a/src/IconAddChartTwoTone.tsx b/src/IconAddChartTwoTone.tsx index b8dbe5571..7e1921651 100644 --- a/src/IconAddChartTwoTone.tsx +++ b/src/IconAddChartTwoTone.tsx @@ -1,7 +1,7 @@ import React from 'react' import { IconProps } from './types' -const IconAddchartTwoTone: React.FC = ({ ...props }) => ( +const IconAddChartTwoTone: React.FC = ({ ...props }) => ( = ({ ...props }) => ( {props.title && {props.title}} - + + + + + + + + + ) -export { IconAddchartTwoTone as default } +export { IconAddChartTwoTone as default } diff --git a/src/IconAddchart.tsx b/src/IconAddchart.tsx index 956777a13..c73d6e623 100644 --- a/src/IconAddchart.tsx +++ b/src/IconAddchart.tsx @@ -1,12 +1,12 @@ import React from 'react' import { IconProps } from './types' -const IconAddchart: React.FC = ({ ...props }) => ( +const IconAddChart: React.FC = ({ ...props }) => ( {props.title && {props.title}} - - + + ) -export { IconAddchart as default } +export { IconAddChart as default } From c335ac16254662243b97bcac5313207c05ca5cb8 Mon Sep 17 00:00:00 2001 From: Alex Lanz Date: Wed, 9 Aug 2023 09:45:04 +0200 Subject: [PATCH 2/2] add comment --- generator.js | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/generator.js b/generator.js index 6625438d8..22b710108 100644 --- a/generator.js +++ b/generator.js @@ -11,7 +11,9 @@ const ICON_FAMILIES = [ { id: 'materialiconstwotone', postfix: 'TwoTone' }, ] -const ignoredIcons = ['addchart'] +const ignoredIcons = [ + 'addchart', // This icon exists twice 'addchart' and 'add_chart'. That's why we decide to only use one version, so that we don't get naming collisions. +] ;(async () => { generatePropsFile()