Skip to content

Commit 23c4f62

Browse files
author
devgioele
committed
fix eslint violations
1 parent 18d6c79 commit 23c4f62

3 files changed

Lines changed: 31 additions & 28 deletions

File tree

src/inMemoryPagination.tsx

Lines changed: 26 additions & 23 deletions
Original file line numberDiff line numberDiff line change
@@ -10,36 +10,39 @@ export const useQueryAndPagination: IUseQueryAndPagination = function (config) {
1010
size: pageSize,
1111
queryParameters: config?.defaultQueryParameters || {},
1212
}),
13-
[]
13+
[firstPage, pageSize, config?.defaultQueryParameters]
1414
)
1515

1616
const [state, setState] = useState(initialState)
1717

18-
const updateQuery = useCallback((queryParameters: QueryParameters) => {
19-
setState((currentState) => {
20-
const updatedQueryParameters = {
21-
...currentState.queryParameters,
22-
...queryParameters,
23-
}
18+
const updateQuery = useCallback(
19+
(queryParameters: QueryParameters) => {
20+
setState((currentState) => {
21+
const updatedQueryParameters = {
22+
...currentState.queryParameters,
23+
...queryParameters,
24+
}
2425

25-
for (const parameter in queryParameters) {
26-
if (
27-
!!config?.defaultQueryParameters &&
28-
(config.defaultQueryParameters[parameter] === undefined ||
29-
config.defaultQueryParameters[parameter] ===
30-
queryParameters[parameter])
31-
) {
32-
delete updatedQueryParameters[parameter]
26+
for (const parameter in queryParameters) {
27+
if (
28+
!!config?.defaultQueryParameters &&
29+
(config.defaultQueryParameters[parameter] === undefined ||
30+
config.defaultQueryParameters[parameter] ===
31+
queryParameters[parameter])
32+
) {
33+
delete updatedQueryParameters[parameter]
34+
}
3335
}
34-
}
3536

36-
return {
37-
...currentState,
38-
page: 0,
39-
queryParameters: updatedQueryParameters,
40-
}
41-
})
42-
}, [])
37+
return {
38+
...currentState,
39+
page: 0,
40+
queryParameters: updatedQueryParameters,
41+
}
42+
})
43+
},
44+
[config?.defaultQueryParameters]
45+
)
4346

4447
const clear = useCallback(() => {
4548
setState(() => {

src/nextRouterPagination.tsx

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -74,7 +74,7 @@ export const useQueryAndPagination: IUseQueryAndPagination = function (config) {
7474
query: params,
7575
})
7676
},
77-
[router]
77+
[router, config?.defaultQueryParameters]
7878
)
7979

8080
const clear = useCallback(() => {
@@ -92,7 +92,7 @@ export const useQueryAndPagination: IUseQueryAndPagination = function (config) {
9292
router.push({
9393
query: params,
9494
})
95-
}, [router])
95+
}, [router, config?.defaultQueryParameters])
9696

9797
return {
9898
queryParameters: extractCurrentQueryParameters(

src/reactRouterPagination.tsx

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -54,7 +54,7 @@ export const useQueryAndPagination: IUseQueryAndPagination = function (config) {
5454
search: params.toString(),
5555
})
5656
},
57-
[navigate, params]
57+
[navigate, params, config?.defaultQueryParameters, routerUrl]
5858
)
5959

6060
const clear = useCallback(() => {
@@ -69,7 +69,7 @@ export const useQueryAndPagination: IUseQueryAndPagination = function (config) {
6969
pathname: routerUrl,
7070
search: params.toString(),
7171
})
72-
}, [navigate, params])
72+
}, [navigate, params, config?.defaultQueryParameters, routerUrl])
7373

7474
const setPage = useCallback(
7575
(page: number) => {
@@ -79,7 +79,7 @@ export const useQueryAndPagination: IUseQueryAndPagination = function (config) {
7979
search: params.toString(),
8080
})
8181
},
82-
[navigate, params]
82+
[navigate, params, routerUrl]
8383
)
8484

8585
return {

0 commit comments

Comments
 (0)