remove reference field from email

Author: SirCotare

src/main/java/it/aboutbits/springboot/emailservice/lib/EmailDto.java

@@ -21,8 +21,6 @@ public record EmailDto(
 
         Set<EmailAttachmentDto> attachments,
 
-        String reference,
-
         OffsetDateTime sendingScheduledAt,
         OffsetDateTime sentAt,
 

src/main/java/it/aboutbits/springboot/emailservice/lib/application/EmailParameter.java

@@ -6,7 +6,6 @@
 import lombok.Builder;
 import lombok.NonNull;
 import lombok.Singular;
-import org.springframework.lang.Nullable;
 
 import java.time.OffsetDateTime;
 import java.util.List;
@@ -16,9 +15,7 @@
 public record EmailParameter(
         @NonNull OffsetDateTime scheduleAt,
 
-        @NonNull Email email,
-
-        @Nullable String reference
+        @NonNull Email email
 ) {
 
     @Builder

src/main/java/it/aboutbits/springboot/emailservice/lib/application/EmailServiceMigrator.java

@@ -29,7 +29,6 @@ void init() {
                      html_body            text                                             not null,
                      attachments          jsonb                    default '[]'::jsonb,
                      sending_scheduled_at timestamp with time zone default now()           not null,
-                     reference            text,
                      sent_at              timestamp with time zone,
                      error_at             timestamp with time zone,
                      error_message        text,
@@ -39,9 +38,6 @@ updated_at           timestamp with time zone default now()           not null,
                          check ((text_body <> ''::text) OR (html_body <> ''::text))
                  );
 
-                 create index if not exists email_service_emails_reference_index
-                     on email_service_emails (reference);
-
                  create index if not exists email_service_emails_state_index
                      on email_service_emails (state);
 

src/main/java/it/aboutbits/springboot/emailservice/lib/application/ManageEmail.java

@@ -51,7 +51,6 @@ public EmailDto schedule(@NonNull @Valid EmailParameter parameter) {
         final var email = new Email();
         email.setState(EmailState.PENDING);
         email.setSendingScheduledAt(parameter.scheduleAt());
-        email.setReference(parameter.reference());
         email.setSubject(emailData.subject());
         email.setTextBody(emailData.textBody());
         email.setHtmlBody(emailData.htmlBody());

src/main/java/it/aboutbits/springboot/emailservice/lib/application/QueryEmail.java

@@ -10,7 +10,6 @@
 import org.springframework.data.domain.Page;
 import org.springframework.data.domain.PageRequest;
 import org.springframework.data.domain.Sort;
-import org.springframework.lang.Nullable;
 
 import java.time.OffsetDateTime;
 import java.util.Collection;
@@ -53,8 +52,4 @@ List<Email> readyToSend() {
     public Optional<EmailDto> byId(long id) {
         return emailRepository.findById(id).map(emailMapper::toDto);
     }
-
-    public List<EmailDto> byReference(@Nullable String reference) {
-        return emailMapper.toDto(emailRepository.findByReference(reference));
-    }
 }

src/main/java/it/aboutbits/springboot/emailservice/lib/jpa/EmailRepository.java

@@ -13,7 +13,5 @@
 public interface EmailRepository extends JpaRepository<Email, Long> {
     Page<Email> findByState(EmailState state, PageRequest pageRequest);
 
-    List<Email> findByReference(String reference);
-
     List<Email> findByIdIn(Collection<Long> ids);
 }

src/main/java/it/aboutbits/springboot/emailservice/lib/model/Email.java

@@ -62,8 +62,6 @@ public class Email {
     @OneToMany(cascade = CascadeType.PERSIST, mappedBy = "email", orphanRemoval = true, fetch = FetchType.EAGER)
     private Set<EmailAttachment> attachments;
 
-    private String reference;
-
     private OffsetDateTime sendingScheduledAt;
     private OffsetDateTime sentAt;
 

src/test/java/it/aboutbits/springboot/emailservice/lib/application/ManageEmailTest.java

@@ -47,7 +47,6 @@ void givenRequiredParameters_schedule_shouldCreateNewNotification() {
         assertThat(result.recipients()).containsAll(parameter.email().recipients());
         assertThat(result.textBody()).isEqualTo(parameter.email().textBody());
         assertThat(result.htmlBody()).isEqualTo(parameter.email().htmlBody());
-        assertThat(result.reference()).isEqualTo(parameter.reference());
         assertThat(result.attachments()).isEmpty();
         assertThat(result.sendingScheduledAt()).isEqualTo(parameter.scheduleAt());
     }
@@ -84,7 +83,6 @@ void givenRequiredParameterWithAttachedFiles_schedule_shouldCreateNewNotificatio
         assertThat(result.recipients()).containsAll(parameter.email().recipients());
         assertThat(result.textBody()).isEqualTo(parameter.email().textBody());
         assertThat(result.htmlBody()).isEqualTo(parameter.email().htmlBody());
-        assertThat(result.reference()).isEqualTo(parameter.reference());
         assertThat(result.attachments()).hasSize(1);
         assertThat(result.sendingScheduledAt()).isEqualTo(parameter.scheduleAt());
     }

src/test/java/it/aboutbits/springboot/emailservice/lib/application/QueryEmailTest.java

@@ -63,21 +63,6 @@ void givenEmailNotificationWithPagination_byState_shouldSuccess() {
         assertThat(result.getContent()).hasSize(1);
     }
 
-    @Test
-    void givenEmailNotificationWithPagination_byReference_shouldSuccess() {
-        emailRepository.saveAll(Set.of(
-                EmailFactory.once().reference("something").build(),
-                EmailFactory.once().reference("something else").build(),
-                EmailFactory.once().reference("something").build()
-        ));
-
-        var result = queryEmail.byReference(
-                "something"
-        );
-
-        assertThat(result).hasSize(2);
-    }
-
     @Test
     void givenEmailNotification_byIds_shouldSuccess() {
         var notificationA = emailRepository.save(EmailFactory.once().build());