requested changes

Author: J0nasMayr

src/main/java/it/aboutbits/springboot/emailservice/lib/application/ManageEmail.java

@@ -72,7 +72,8 @@ public EmailDto sendOrFail(@Valid EmailParameter parameter) throws EmailExceptio
         var savedEmail = send(email);
 
         if (savedEmail.hasFailed()) {
-            throw new EmailException(savedEmail.getErrorMessage());
+            var errorMessage = savedEmail.getErrorMessage();
+            throw new EmailException(errorMessage != null ? errorMessage : "");
         }
 
         return emailMapper.toDto(savedEmail);

src/main/java/it/aboutbits/springboot/emailservice/lib/exception/AttachmentException.java

@@ -1,30 +1,30 @@
 package it.aboutbits.springboot.emailservice.lib.exception;
 
-import org.jspecify.annotations.NullUnmarked;
+import org.jspecify.annotations.NullMarked;
 
-@NullUnmarked
+@NullMarked
 public class AttachmentException extends Exception {
     public AttachmentException() {
         super();
     }
 
-    public AttachmentException(final String message) {
+    public AttachmentException(String message) {
         super(message);
     }
 
-    public AttachmentException(final String message, final Throwable cause) {
+    public AttachmentException(String message, Throwable cause) {
         super(message, cause);
     }
 
-    public AttachmentException(final Throwable cause) {
+    public AttachmentException(Throwable cause) {
         super(cause);
     }
 
     protected AttachmentException(
-            final String message,
-            final Throwable cause,
-            final boolean enableSuppression,
-            final boolean writableStackTrace
+            String message,
+            Throwable cause,
+            boolean enableSuppression,
+            boolean writableStackTrace
     ) {
         super(message, cause, enableSuppression, writableStackTrace);
     }

src/main/java/it/aboutbits/springboot/emailservice/lib/exception/EmailException.java

@@ -1,8 +1,8 @@
 package it.aboutbits.springboot.emailservice.lib.exception;
 
-import org.jspecify.annotations.NullUnmarked;
+import org.jspecify.annotations.NullMarked;
 
-@NullUnmarked
+@NullMarked
 public class EmailException extends Exception {
     public EmailException() {
         super();

src/main/java/it/aboutbits/springboot/emailservice/lib/model/Email.java

@@ -22,6 +22,7 @@
 import org.hibernate.annotations.UpdateTimestamp;
 import org.hibernate.type.SqlTypes;
 import org.jspecify.annotations.NullUnmarked;
+import org.jspecify.annotations.Nullable;
 
 import java.time.OffsetDateTime;
 import java.util.List;
@@ -59,7 +60,9 @@ public class Email {
     private String fromAddress;
     private String fromName;
 
+    @Nullable
     private String replyToAddress;
+    @Nullable
     private String replyToName;
 
     @JdbcTypeCode(SqlTypes.JSON)
@@ -75,9 +78,12 @@ public class Email {
     private boolean attachmentsCleaned = false;
 
     private OffsetDateTime scheduledAt;
+    @Nullable
     private OffsetDateTime sentAt;
 
+    @Nullable
     private OffsetDateTime errorAt;
+    @Nullable
     private String errorMessage;
 
     @CreationTimestamp