remove redundant faker instance already present in superclass. prevent duplicate save call when no result mutator is set.

Author: SirCotare

src/main/java/it/aboutbits/springboot/testing/testdata/base/ModifiableTestDataCreator.java

@@ -2,6 +2,7 @@
 
 import lombok.extern.slf4j.Slf4j;
 import org.jspecify.annotations.NullMarked;
+import org.jspecify.annotations.Nullable;
 
 import java.util.ArrayList;
 import java.util.List;
@@ -14,9 +15,6 @@
 @Slf4j
 @NullMarked
 public abstract class ModifiableTestDataCreator<CREATOR extends ModifiableTestDataCreator<CREATOR, ITEM, PARAMETER>, ITEM, PARAMETER> extends TestDataCreator<ITEM> {
-    @SuppressWarnings("unused")
-    protected static final FakerExtended FAKER = new FakerExtended();
-
     private boolean mutatorSet = false;
     private boolean mutatorCalled = false;
 
@@ -25,8 +23,8 @@ public abstract class ModifiableTestDataCreator<CREATOR extends ModifiableTestDa
         return parameter;
     };
 
-    protected ObjIntConsumer<ITEM> resultMutator = (_, _) -> {
-    };
+    @Nullable
+    protected ObjIntConsumer<ITEM> resultMutator = null;
 
     protected ModifiableTestDataCreator(int count) {
         super(count);
@@ -71,11 +69,15 @@ protected List<ITEM> create() {
         for (var index = 0; index < numberOfItems; index++) {
             var item = create(index);
 
-            resultMutator.accept(item, index);
+            if (resultMutator != null) {
+                resultMutator.accept(item, index);
 
-            result.add(
-                    saveMutation(item)
-            );
+                result.add(
+                        saveMutation(item)
+                );
+            } else {
+                result.add(item);
+            }
         }
 
         if (mutatorSet && !mutatorCalled) {