Skip to content

add helper to generate entity ids - #11

Merged
SirCotare merged 3 commits into
mainfrom
add_faker_id_generator
Jan 22, 2025
Merged

add helper to generate entity ids#11
SirCotare merged 3 commits into
mainfrom
add_faker_id_generator

Conversation

@SirCotare

Copy link
Copy Markdown
Member

No description provided.

@SirCotare SirCotare self-assigned this Jan 22, 2025
@SirCotare
SirCotare requested a review from ThoSap January 22, 2025 09:20

@ThoSap ThoSap left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice, but keep in mind that we also have some EntityId<String> as for example for the Role.ID, Authority.ID and User.ID in the Finstral Composer Project.

@SirCotare

Copy link
Copy Markdown
Member Author

Nice, but keep in mind that we also have some EntityId<String> as for example for the Role.ID, Authority.ID and User.ID in the Finstral Composer Project.

I added some generic string version of the method. I know it will not be usable in some cases where the ID has to follow some special rules but in general that should do.
Also, string ids are probably very rare anyway in our systems.

@SirCotare
SirCotare merged commit 9a37b74 into main Jan 22, 2025
@SirCotare
SirCotare deleted the add_faker_id_generator branch January 22, 2025 10:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants