From 72c9cef0a53268b2ca4d2ff8fb15c406c2eb2259 Mon Sep 17 00:00:00 2001
From: Andreas Hufler <andreas.hufler@aboutbits.it>
Date: Wed, 16 Oct 2024 17:05:38 +0200
Subject: [PATCH 1/5] update checkstyle IDE config

---
 .idea/checkstyle-idea.xml | 13 ++++++-------
 1 file changed, 6 insertions(+), 7 deletions(-)

diff --git a/.idea/checkstyle-idea.xml b/.idea/checkstyle-idea.xml
index 05f5e1f..cd93c1e 100644
--- a/.idea/checkstyle-idea.xml
+++ b/.idea/checkstyle-idea.xml
@@ -1,22 +1,21 @@
 <?xml version="1.0" encoding="UTF-8"?>
 <project version="4">
   <component name="CheckStyle-IDEA" serialisationVersion="2">
-    <checkstyleVersion>10.12.5</checkstyleVersion>
-    <scanScope>JavaOnlyWithTests</scanScope>
+    <checkstyleVersion>10.18.1</checkstyleVersion>
+    <scanScope>JavaOnly</scanScope>
     <option name="thirdPartyClasspath" />
     <option name="activeLocationIds">
-      <option value="e5e05351-1d19-4e8f-8139-4fee966b9e88" />
+      <option value="4cf94184-80ae-47a8-8a7e-ca8ee05f485e" />
     </option>
     <option name="locations">
       <list>
         <ConfigurationLocation id="bundled-sun-checks" type="BUNDLED" scope="All" description="Sun Checks">(bundled)</ConfigurationLocation>
         <ConfigurationLocation id="bundled-google-checks" type="BUNDLED" scope="All" description="Google Checks">(bundled)</ConfigurationLocation>
-        <ConfigurationLocation id="e5e05351-1d19-4e8f-8139-4fee966b9e88" type="LOCAL_FILE" scope="All" description="aboutbits">
-          $PROJECT_DIR$/checkstyle.xml
+        <ConfigurationLocation id="4cf94184-80ae-47a8-8a7e-ca8ee05f485e" type="LOCAL_FILE" scope="All" description="aboutbits">
+          $PROJECT_DIR$/target/checkstyle-checker.xml
           <option name="properties">
             <map>
-              <entry key="org.checkstyle.sun.suppressionfilter.config" value="" />
-              <entry key="org.checkstyle.sun.suppressionxpathfilter.config" value="" />
+              <entry key="org.checkstyle.sun.suppressionfilter.config" value="checkstyle-suppressions.xml" />
             </map>
           </option>
         </ConfigurationLocation>

From d25012356e911151e9c66e54155ee589d13a5507 Mon Sep 17 00:00:00 2001
From: Andreas Hufler <andreas.hufler@aboutbits.it>
Date: Wed, 13 Nov 2024 12:09:21 +0100
Subject: [PATCH 2/5] include faker by default

---
 pom.xml                                                  | 9 +++++++--
 .../testing/testdata/base/ModifyableTestDataCreator.java | 3 +++
 .../testing/testdata/base/TestDataCreator.java           | 3 +++
 3 files changed, 13 insertions(+), 2 deletions(-)

diff --git a/pom.xml b/pom.xml
index 8aa326a..6fbb898 100644
--- a/pom.xml
+++ b/pom.xml
@@ -6,7 +6,7 @@
     <parent>
         <groupId>org.springframework.boot</groupId>
         <artifactId>spring-boot-starter-parent</artifactId>
-        <version>3.3.4</version>
+        <version>3.3.5</version>
         <relativePath/> <!-- lookup parent from repository -->
     </parent>
 
@@ -24,7 +24,7 @@
             <dependency>
                 <groupId>it.aboutbits</groupId>
                 <artifactId>spring-boot-toolbox</artifactId>
-                <version>1.0.0-RC4</version>
+                <version>1.0.0-RC6</version>
             </dependency>
         </dependencies>
     </dependencyManagement>
@@ -52,6 +52,11 @@
             <groupId>org.springframework.boot</groupId>
             <artifactId>spring-boot-starter-test</artifactId>
         </dependency>
+        <dependency>
+            <groupId>net.datafaker</groupId>
+            <artifactId>datafaker</artifactId>
+            <version>2.4.1</version>
+        </dependency>
     </dependencies>
 
     <build>
diff --git a/src/main/java/it/aboutbits/springboot/testing/testdata/base/ModifyableTestDataCreator.java b/src/main/java/it/aboutbits/springboot/testing/testdata/base/ModifyableTestDataCreator.java
index 39eec6e..a6c791e 100644
--- a/src/main/java/it/aboutbits/springboot/testing/testdata/base/ModifyableTestDataCreator.java
+++ b/src/main/java/it/aboutbits/springboot/testing/testdata/base/ModifyableTestDataCreator.java
@@ -2,6 +2,7 @@
 
 import lombok.NonNull;
 import lombok.extern.slf4j.Slf4j;
+import net.datafaker.Faker;
 
 import java.util.ArrayList;
 import java.util.List;
@@ -13,6 +14,8 @@
 @SuppressWarnings("unchecked")
 @Slf4j
 public abstract class ModifyableTestDataCreator<CREATOR extends ModifyableTestDataCreator<CREATOR, ITEM, PARAMETER>, ITEM, PARAMETER> extends TestDataCreator<ITEM> {
+    protected static final Faker FAKER = new Faker();
+
     private boolean mutatorSet = false;
     private boolean mutatorCalled = false;
 
diff --git a/src/main/java/it/aboutbits/springboot/testing/testdata/base/TestDataCreator.java b/src/main/java/it/aboutbits/springboot/testing/testdata/base/TestDataCreator.java
index 25f2fb6..6c4418e 100644
--- a/src/main/java/it/aboutbits/springboot/testing/testdata/base/TestDataCreator.java
+++ b/src/main/java/it/aboutbits/springboot/testing/testdata/base/TestDataCreator.java
@@ -1,6 +1,7 @@
 package it.aboutbits.springboot.testing.testdata.base;
 
 import lombok.NonNull;
+import net.datafaker.Faker;
 
 import java.util.ArrayList;
 import java.util.Comparator;
@@ -10,6 +11,8 @@
 import java.util.function.Function;
 
 public abstract class TestDataCreator<ITEM> {
+    protected static final Faker FAKER = new Faker();
+
     protected final int numberOfItems;
 
     protected TestDataCreator(int numberIfItems) {

From b1fd1f9b75f0e861c3e2f71f57edf13f829358fb Mon Sep 17 00:00:00 2001
From: Andreas Hufler <andreas.hufler@aboutbits.it>
Date: Thu, 28 Nov 2024 09:00:03 +0100
Subject: [PATCH 3/5] use an extended faker to provide custom utilities

---
 .../testing/testdata/base/FakerExtended.java  | 40 +++++++++++++++++++
 .../base/ModifyableTestDataCreator.java       |  3 +-
 .../testdata/base/TestDataCreator.java        |  3 +-
 3 files changed, 42 insertions(+), 4 deletions(-)
 create mode 100644 src/main/java/it/aboutbits/springboot/testing/testdata/base/FakerExtended.java

diff --git a/src/main/java/it/aboutbits/springboot/testing/testdata/base/FakerExtended.java b/src/main/java/it/aboutbits/springboot/testing/testdata/base/FakerExtended.java
new file mode 100644
index 0000000..ed02882
--- /dev/null
+++ b/src/main/java/it/aboutbits/springboot/testing/testdata/base/FakerExtended.java
@@ -0,0 +1,40 @@
+package it.aboutbits.springboot.testing.testdata.base;
+
+import net.datafaker.Faker;
+import net.datafaker.service.FakeValuesService;
+import net.datafaker.service.FakerContext;
+import net.datafaker.service.RandomService;
+
+import java.util.Locale;
+import java.util.Random;
+
+public class FakerExtended extends Faker {
+    public FakerExtended() {
+        super();
+    }
+
+    public FakerExtended(Locale locale) {
+        super(locale);
+    }
+
+    public FakerExtended(Random random) {
+        super(random);
+    }
+
+    public FakerExtended(Locale locale, Random random) {
+        super(locale, random);
+    }
+
+    public FakerExtended(Locale locale, RandomService randomService) {
+        super(locale, randomService);
+    }
+
+    public FakerExtended(FakeValuesService fakeValuesService, FakerContext context) {
+        super(fakeValuesService, context);
+    }
+
+    public <T extends Enum<?>> T randomEnumValue(Class<T> enumClass) {
+        var values = enumClass.getEnumConstants();
+        return values[this.random().nextInt(values.length)];
+    }
+}
diff --git a/src/main/java/it/aboutbits/springboot/testing/testdata/base/ModifyableTestDataCreator.java b/src/main/java/it/aboutbits/springboot/testing/testdata/base/ModifyableTestDataCreator.java
index a6c791e..a959563 100644
--- a/src/main/java/it/aboutbits/springboot/testing/testdata/base/ModifyableTestDataCreator.java
+++ b/src/main/java/it/aboutbits/springboot/testing/testdata/base/ModifyableTestDataCreator.java
@@ -2,7 +2,6 @@
 
 import lombok.NonNull;
 import lombok.extern.slf4j.Slf4j;
-import net.datafaker.Faker;
 
 import java.util.ArrayList;
 import java.util.List;
@@ -14,7 +13,7 @@
 @SuppressWarnings("unchecked")
 @Slf4j
 public abstract class ModifyableTestDataCreator<CREATOR extends ModifyableTestDataCreator<CREATOR, ITEM, PARAMETER>, ITEM, PARAMETER> extends TestDataCreator<ITEM> {
-    protected static final Faker FAKER = new Faker();
+    protected static final FakerExtended FAKER = new FakerExtended();
 
     private boolean mutatorSet = false;
     private boolean mutatorCalled = false;
diff --git a/src/main/java/it/aboutbits/springboot/testing/testdata/base/TestDataCreator.java b/src/main/java/it/aboutbits/springboot/testing/testdata/base/TestDataCreator.java
index 6c4418e..80d0077 100644
--- a/src/main/java/it/aboutbits/springboot/testing/testdata/base/TestDataCreator.java
+++ b/src/main/java/it/aboutbits/springboot/testing/testdata/base/TestDataCreator.java
@@ -1,7 +1,6 @@
 package it.aboutbits.springboot.testing.testdata.base;
 
 import lombok.NonNull;
-import net.datafaker.Faker;
 
 import java.util.ArrayList;
 import java.util.Comparator;
@@ -11,7 +10,7 @@
 import java.util.function.Function;
 
 public abstract class TestDataCreator<ITEM> {
-    protected static final Faker FAKER = new Faker();
+    protected static final FakerExtended FAKER = new FakerExtended();
 
     protected final int numberOfItems;
 

From c449a2bd5c1965e44ba5457a5e5b3865e679ded1 Mon Sep 17 00:00:00 2001
From: Andreas Hufler <andreas.hufler@aboutbits.it>
Date: Thu, 28 Nov 2024 09:03:22 +0100
Subject: [PATCH 4/5] update libs

---
 pom.xml | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/pom.xml b/pom.xml
index 6fbb898..d83a8f9 100644
--- a/pom.xml
+++ b/pom.xml
@@ -6,7 +6,7 @@
     <parent>
         <groupId>org.springframework.boot</groupId>
         <artifactId>spring-boot-starter-parent</artifactId>
-        <version>3.3.5</version>
+        <version>3.3.6</version>
         <relativePath/> <!-- lookup parent from repository -->
     </parent>
 
@@ -55,7 +55,7 @@
         <dependency>
             <groupId>net.datafaker</groupId>
             <artifactId>datafaker</artifactId>
-            <version>2.4.1</version>
+            <version>2.4.2</version>
         </dependency>
     </dependencies>
 

From 564f3dd39059e95547689f09eb0c7fa167688dd6 Mon Sep 17 00:00:00 2001
From: Andreas Hufler <andreas.hufler@aboutbits.it>
Date: Thu, 28 Nov 2024 09:10:04 +0100
Subject: [PATCH 5/5] add check to handle empty enums

---
 .../springboot/testing/testdata/base/FakerExtended.java        | 3 +++
 1 file changed, 3 insertions(+)

diff --git a/src/main/java/it/aboutbits/springboot/testing/testdata/base/FakerExtended.java b/src/main/java/it/aboutbits/springboot/testing/testdata/base/FakerExtended.java
index ed02882..e23688f 100644
--- a/src/main/java/it/aboutbits/springboot/testing/testdata/base/FakerExtended.java
+++ b/src/main/java/it/aboutbits/springboot/testing/testdata/base/FakerExtended.java
@@ -35,6 +35,9 @@ public FakerExtended(FakeValuesService fakeValuesService, FakerContext context)
 
     public <T extends Enum<?>> T randomEnumValue(Class<T> enumClass) {
         var values = enumClass.getEnumConstants();
+        if (values.length == 0) {
+            throw new IllegalArgumentException("Enum class must have at least one value");
+        }
         return values[this.random().nextInt(values.length)];
     }
 }