implement review feedback

Author: ThoSap

src/main/java/it/aboutbits/springboot/toolbox/parameter/SortParameter.java

@@ -263,16 +263,23 @@ private static String convertToString(Object value) {
             return string;
         }
 
-        // Use reflection to get the column name from a mapped jOOQ Field<?> using the Field<?>.getName() method
+        // Use reflection to get the column name from a jOOQ Field<?> using the Field<?>.getName() method
         // This allows us to have jOOQ as an optional dependency and not break existing projects that use Hibernate
         try {
-            var getName = findAccessibleGetNameMethod(value.getClass());
-            if (getName == null) {
-                getName = value.getClass().getMethod("getName");
-                getName.setAccessible(true);
+            var fieldClass = Class.forName("org.jooq.Field");
+            if (!fieldClass.isInstance(value)) {
+                throw new IllegalArgumentException(
+                        "Value must be either a String or org.jooq.Field, but was: " + value.getClass().getName()
+                );
             }
 
+            var getName = fieldClass.getMethod("getName");
             return (String) getName.invoke(value);
+        } catch (ClassNotFoundException e) {
+            throw new IllegalArgumentException(
+                    "jOOQ library not found. Cannot process Field<?> value. Make sure jOOQ is on the classpath.",
+                    e
+            );
         } catch (Exception e) {
             throw new IllegalArgumentException(
                     "Cannot get the jOOQ Field name from the mapped SortMappings$Mapping column value [value.class.name=%s]".formatted(
@@ -283,33 +290,6 @@ private static String convertToString(Object value) {
         }
     }
 
-    private static @Nullable Method findAccessibleGetNameMethod(Class<?> clazz) {
-        if (Modifier.isPublic(clazz.getModifiers())) {
-            try {
-                var method = clazz.getDeclaredMethod("getName");
-                if (Modifier.isPublic(method.getModifiers())) {
-                    return method;
-                }
-            } catch (NoSuchMethodException _) {
-                // ignored, let's search in the interfaces or superclass
-            }
-        }
-
-        for (var interFace : clazz.getInterfaces()) {
-            var method = findAccessibleGetNameMethod(interFace);
-            if (method != null) {
-                return method;
-            }
-        }
-
-        var superclass = clazz.getSuperclass();
-        if (superclass != null) {
-            return findAccessibleGetNameMethod(superclass);
-        }
-
-        return null;
-    }
-
     private Sort buildSort(Map<String, String> mapping, boolean withDefault) {
         if (sortFields.isEmpty()) {
             return withDefault ? getMappedDefaultSort(mapping) : Sort.unsorted();

src/main/java/it/aboutbits/springboot/toolbox/persistence/SortMappings.java

@@ -5,6 +5,13 @@
 
 import java.util.HashMap;
 
+/// A mapping of sort parameter definitions to their corresponding database columns.
+///
+/// The values in this map are of type [Object] and are expected to be either:
+/// - [String] - for column names when using Hibernate/JPA
+/// - `org.jooq.Field<?>` - for jOOQ field objects when using jOOQ
+///
+/// @param <T> the enum type that implements [SortParameter.Definition]
 @NullMarked
 public class SortMappings<T extends Enum<?> & SortParameter.Definition> extends HashMap<T, Object> {
     SortMappings() {

src/test/java/it/aboutbits/springboot/toolbox/persistence/SortMappingsForJooqTest.java

@@ -3,6 +3,7 @@
 import it.aboutbits.springboot.toolbox.parameter.SortParameter;
 import org.jooq.impl.DSL;
 import org.jspecify.annotations.NullMarked;
+import org.junit.jupiter.api.DisplayName;
 import org.junit.jupiter.api.Test;
 import org.springframework.data.domain.Sort;
 
@@ -18,6 +19,7 @@ private enum ESort implements SortParameter.Definition {
     }
 
     @Test
+    @DisplayName("Method map should return a mapping with a jOOQ Field object")
     void map_shouldReturnMappingWithFieldObject() {
         var field = DSL.field("my_column");
         var mapping = SortMappingsForJooq.map(ESort.Property1, field);
@@ -27,6 +29,7 @@ void map_shouldReturnMappingWithFieldObject() {
     }
 
     @Test
+    @DisplayName("Method of should create a SortMappingsForJooq instance")
     void of_shouldCreateSortMappingsForJooq() {
         var field1 = DSL.field("col1");
         var mappings = SortMappingsForJooq.of(
@@ -38,6 +41,7 @@ void of_shouldCreateSortMappingsForJooq() {
     }
 
     @Test
+    @DisplayName("Should build Spring Sort with jOOQ Fields correctly")
     void buildSpringSortWithJooqFields() {
         var mappings = SortMappingsForJooq.of(
                 SortMappingsForJooq.map(ESort.Property1, DSL.field("my_col"))