Skip to content

Commit c2fcc36

Browse files
authored
Merge pull request #2 from aboutbits/improve-package
Improve package
2 parents baf7029 + f1a86fc commit c2fcc36

8 files changed

Lines changed: 431 additions & 1313 deletions

File tree

.eslintignore

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,2 @@
1+
/dist
2+
/node_modules

.eslintrc.json

Lines changed: 43 additions & 15 deletions
Original file line numberDiff line numberDiff line change
@@ -1,41 +1,69 @@
11
{
2+
"root": true,
23
"parser": "@typescript-eslint/parser",
34
"env": {
4-
"node": true,
55
"browser": true,
6-
"es6": true,
7-
"commonjs": true
6+
"es2020": true
87
},
98
"plugins": [
109
"@typescript-eslint",
1110
"import",
11+
"react",
12+
"react-hooks",
1213
"prettier",
1314
"formatjs"
1415
],
1516
"extends": [
17+
"eslint:recommended",
1618
"plugin:@typescript-eslint/recommended",
17-
"plugin:prettier/recommended",
19+
"plugin:react/recommended",
20+
"plugin:react/jsx-runtime",
1821
"plugin:import/recommended",
1922
"plugin:import/typescript",
20-
"plugin:jest/recommended"
23+
"plugin:prettier/recommended"
2124
],
22-
"parserOptions": {
23-
"sourceType": "module",
24-
"ecmaVersion": 2018
25+
"settings": {
26+
"react": {
27+
"version": "detect"
28+
}
2529
},
2630
"rules": {
31+
"react-hooks/rules-of-hooks": "error",
32+
"react-hooks/exhaustive-deps": "warn",
2733
"@typescript-eslint/no-unused-vars": "error",
2834
"@typescript-eslint/member-delimiter-style": "off",
2935
"@typescript-eslint/explicit-function-return-type": "off",
30-
"formatjs/enforce-default-message": ["error", "literal"],
31-
"formatjs/enforce-placeholders": "error",
32-
"formatjs/no-multiple-whitespaces": "error",
33-
"formatjs/enforce-id": "error",
3436
"import/order": [
3537
"error",
3638
{
37-
"groups": ["builtin", "external", "unknown", "parent", "sibling", "index"]
39+
"groups": [
40+
"builtin",
41+
"external",
42+
"unknown",
43+
"parent",
44+
"sibling",
45+
"index"
46+
]
47+
}
48+
],
49+
"formatjs/enforce-default-message": ["error", "literal"],
50+
"formatjs/enforce-placeholders": "error",
51+
"formatjs/no-multiple-whitespaces": "error",
52+
"formatjs/enforce-id": "error"
53+
},
54+
"overrides": [
55+
{
56+
"files": ["*.js"],
57+
"env": {
58+
"node": true
3859
}
39-
]
40-
}
60+
},
61+
{
62+
"files": ["*.test.ts", "*.test.tsx"],
63+
"env": {
64+
"jest": true
65+
},
66+
"extends": ["plugin:jest/recommended"]
67+
}
68+
]
4169
}

.githooks/pre-commit

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -4,3 +4,4 @@ set -e
44
set -o pipefail
55

66
npm run lint
7+
npm run typecheck

.github/workflows/main.yml

Lines changed: 4 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -9,12 +9,11 @@ jobs:
99
checks:
1010
runs-on: ubuntu-20.04
1111
steps:
12-
- uses: actions/checkout@v2
13-
- uses: actions/setup-node@v1
12+
- uses: actions/checkout@v3
13+
- uses: actions/setup-node@v3
1414
with:
15-
node-version: '16.x'
16-
registry-url: 'https://registry.npmjs.org'
17-
- uses: actions/cache@v2
15+
node-version: 16
16+
- uses: actions/cache@v3
1817
with:
1918
path: ~/.npm
2019
key: ${{ runner.os }}-npm-${{ hashFiles('**/package-lock.json') }}

.github/workflows/release-package.yml

Lines changed: 3 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -7,7 +7,7 @@ jobs:
77
build:
88
runs-on: ubuntu-latest
99
steps:
10-
- uses: actions/checkout@v2
10+
- uses: actions/checkout@v3
1111
- uses: actions/create-release@v1
1212
env:
1313
GITHUB_TOKEN: ${{ secrets.GITHUB_TOKEN }}
@@ -16,10 +16,9 @@ jobs:
1616
release_name: Release ${{ github.ref }}
1717
draft: false
1818
prerelease: false
19-
- uses: actions/setup-node@v1
19+
- uses: actions/setup-node@v3
2020
with:
21-
node-version: '16.x'
22-
registry-url: 'https://registry.npmjs.org'
21+
node-version: 16
2322
- run: npm ci
2423
- run: npm publish
2524
env:

.gitignore

Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -9,3 +9,6 @@
99
/node_modules
1010
/dist
1111
/translations-template.json
12+
13+
# ESLint
14+
.eslintcache

0 commit comments

Comments
 (0)