This repository was archived by the owner on May 21, 2026. It is now read-only.
Fix conversation memory duplication bug - #39
Open
lightsblue wants to merge 1 commit into
Open
Conversation
- Move user message addition from before to after LLM processing - Prevents duplicate messages in conversation history - Ensures chat_history only contains previous messages, not current
lightsblue
force-pushed
the
fix/conversation-memory-duplication
branch
from
September 3, 2025 16:20
5c3685c to
36b1a5e
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Fixes conversation memory duplication where user messages appeared twice in API requests sent to the LLM.
The bug occurred in both
stream()andstreamEvents()methods - the current user message was being added toconversationHistoryBEFORE sending the request to the LLM, which meant it appeared in both the
chat_historyarray and theinputparameter.This fix moves the
addToHistory()call to AFTER the LLM completes processing, ensuring conversation history only contains previousmessages during LLM processing.
Type of change
Checklist
Note: I left "tests" and "documentation" unchecked since: