Add flow into the list - #3

Reviewing files that changed from the base of the PR and between 241658a and 6d69a2c.

• src/core/chains.ts (9 hunks)

src/core/chains.ts (4)

33-33: Properly imports Flow blockchain chains.

The addition of Flow blockchain imports for both mainnet and testnet follows the existing pattern of separating mainnet and testnet imports. The imports are placed correctly.

Also applies to: 57-57

---

344-344: Minor formatting change.

Added trailing space in function definition - not significant but maintains consistent formatting.

---

246-246:

Details

✅ Verification successful

RPC URLs added for Flow blockchain networks.

The RPC URLs for Flow mainnet ('https://mainnet.evm.nodes.onflow.org') and testnet ('https://testnet.evm.nodes.onflow.org') have been correctly added to the rpcUrlMap.

Also applies to: 270-270

---

🏁 Script executed:

#!/bin/bash
# Verify that the Flow RPC URLs are accessible
echo "Verifying Flow RPC URL accessibility:"
curl -s -X POST -H "Content-Type: application/json" --data '{"jsonrpc":"2.0","method":"eth_chainId","params":[],"id":1}' https://mainnet.evm.nodes.onflow.org | grep "result"
curl -s -X POST -H "Content-Type: application/json" --data '{"jsonrpc":"2.0","method":"eth_chainId","params":[],"id":1}' https://testnet.evm.nodes.onflow.org | grep "result"

Length of output: 516

---

Flow RPC URLs for mainnet and testnet verified successfully.

After running the verification script, both RPC endpoints are fully functional:

• Flow Mainnet: Returned chain ID 0x2eb from 'https://mainnet.evm.nodes.onflow.org'
• Flow Testnet: Returned chain ID 0x221 from 'https://testnet.evm.nodes.onflow.org'

The additions in src/core/chains.ts (lines 246 and 270) to include these endpoints in the rpcUrlMap are correct and require no further action.

---

96-96:

Details

✅ Verification successful

Flow blockchain chain configurations correctly added.

Flow mainnet (ID: 747) and testnet (ID: 545) are properly added to the chainMap, maintaining the separation between mainnet and testnet entries.

Also applies to: 120-120

---

🏁 Script executed:

#!/bin/bash
# Verify that the Flow chain IDs are correct
echo "Verifying Flow chain IDs against references"
curl -s https://chainlist.org/chain/747 | grep -i "flow mainnet" || echo "Flow mainnet ID 747 not found on chainlist.org"
curl -s https://chainlist.org/chain/545 | grep -i "flow testnet" || echo "Flow testnet ID 545 not found on chainlist.org"

# Alternative verification using the provided links in PR
curl -s https://raw.githubusercontent.com/wevm/viem/main/src/chains/definitions/flowMainnet.ts | grep -A 5 "id:" | grep -A 1 747
curl -s https://raw.githubusercontent.com/wevm/viem/main/src/chains/definitions/flowTestnet.ts | grep -A 5 "id:" | grep -A 1 545

Length of output: 772

---

Verified Flow Chain Configurations: IDs Are Correct

The Flow blockchain configurations have been confirmed as follows:

• Flow Mainnet (ID: 747): The GitHub definition file (src/chains/definitions/flowMainnet.ts) shows the correct entry with id: 747 and name "Flow EVM Mainnet."
• Flow Testnet (ID: 545): The definition file (src/chains/definitions/flowTestnet.ts) confirms the entry with id: 545 and name "Flow EVM Testnet."

Although the chainlist.org queries did not return the expected string matches, the alternative verification clearly confirms the configurations. No further changes are needed.