Skip to content

Commit 0cbaed6

Browse files
author
Mohammod Al Amin Ashik
committed
fix: Skip Tauri-dependent tests in web E2E and add signing password to workflows
- Skip update checker tests in web mode (require Tauri invoke API) - Skip logs path test in web mode (requires Tauri invoke API) - Add TAURI_SIGNING_PRIVATE_KEY_PASSWORD to CI, e2e-desktop, and nightly workflows Fixes 3 failing web E2E tests that were trying to call desktop-only Tauri commands. These tests are properly covered in desktop E2E tests (settings-desktop.wdio.ts).
1 parent 6e34ae4 commit 0cbaed6

4 files changed

Lines changed: 33 additions & 24 deletions

File tree

‎.github/workflows/ci.yml‎

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -242,6 +242,7 @@ jobs:
242242
- run: pnpm build
243243
env:
244244
TAURI_SIGNING_PRIVATE_KEY: ${{ secrets.TAURI_SIGNING_PRIVATE_KEY }}
245+
TAURI_SIGNING_PRIVATE_KEY_PASSWORD: ${{ secrets.TAURI_SIGNING_PRIVATE_KEY_PASSWORD }}
245246

246247
# ─────────────────────────────────────────────────────────────
247248
# Test Results Report (separate checks per test type and OS)

‎.github/workflows/e2e-desktop.yml‎

Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -12,6 +12,8 @@ on:
1212
secrets:
1313
TAURI_SIGNING_PRIVATE_KEY:
1414
required: false
15+
TAURI_SIGNING_PRIVATE_KEY_PASSWORD:
16+
required: false
1517

1618
env:
1719
PKG_CONFIG_PATH: /usr/lib/x86_64-linux-gnu/pkgconfig:/usr/lib/pkgconfig:/usr/share/pkgconfig
@@ -100,6 +102,7 @@ jobs:
100102
env:
101103
PKG_CONFIG_PATH: /usr/lib/x86_64-linux-gnu/pkgconfig:/usr/lib/pkgconfig:/usr/share/pkgconfig
102104
TAURI_SIGNING_PRIVATE_KEY: ${{ secrets.TAURI_SIGNING_PRIVATE_KEY }}
105+
TAURI_SIGNING_PRIVATE_KEY_PASSWORD: ${{ secrets.TAURI_SIGNING_PRIVATE_KEY_PASSWORD }}
103106

104107
- name: Run desktop E2E tests (Linux)
105108
if: matrix.os == 'ubuntu-latest'

‎.github/workflows/nightly.yml‎

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -57,6 +57,7 @@ jobs:
5757
- run: pnpm build
5858
env:
5959
TAURI_SIGNING_PRIVATE_KEY: ${{ secrets.TAURI_SIGNING_PRIVATE_KEY }}
60+
TAURI_SIGNING_PRIVATE_KEY_PASSWORD: ${{ secrets.TAURI_SIGNING_PRIVATE_KEY_PASSWORD }}
6061
PKG_CONFIG_PATH: /usr/lib/x86_64-linux-gnu/pkgconfig:/usr/lib/pkgconfig:/usr/share/pkgconfig
6162

6263
- name: Upload artifacts

‎tests/e2e/specs/settings.spec.ts‎

Lines changed: 28 additions & 24 deletions
Original file line numberDiff line numberDiff line change
@@ -5,18 +5,18 @@ test.describe('Settings', () => {
55
test('should display settings heading', async ({ page }) => {
66
const dashboard = new DashboardPage(page);
77
await dashboard.navigate();
8-
8+
99
// Click Settings in sidebar
1010
await page.locator('nav button:has-text("Settings")').click();
11-
11+
1212
// Check heading
1313
await expect(page.getByRole('heading', { name: 'Settings' })).toBeVisible();
1414
});
1515

1616
test('should display appearance settings', async ({ page }) => {
1717
const dashboard = new DashboardPage(page);
1818
await dashboard.navigate();
19-
19+
2020
await page.locator('nav button:has-text("Settings")').click();
2121

2222
await expect(page.locator('text=Appearance').first()).toBeVisible();
@@ -27,7 +27,7 @@ test.describe('Settings', () => {
2727
test('should display logs section', async ({ page }) => {
2828
const dashboard = new DashboardPage(page);
2929
await dashboard.navigate();
30-
30+
3131
await page.locator('nav button:has-text("Settings")').click();
3232

3333
// Use heading role to be more specific
@@ -37,13 +37,13 @@ test.describe('Settings', () => {
3737
test('should switch between themes', async ({ page }) => {
3838
const dashboard = new DashboardPage(page);
3939
await dashboard.navigate();
40-
40+
4141
await page.locator('nav button:has-text("Settings")').click();
4242

4343
// Switch to light theme
4444
await page.getByRole('button', { name: 'Light', exact: true }).click();
4545
await page.waitForTimeout(300);
46-
46+
4747
// Switch to dark theme
4848
await page.getByRole('button', { name: 'Dark', exact: true }).click();
4949
await page.waitForTimeout(300);
@@ -54,7 +54,7 @@ test.describe('Settings', () => {
5454
test('should display update checker section', async ({ page }) => {
5555
const dashboard = new DashboardPage(page);
5656
await dashboard.navigate();
57-
57+
5858
await page.locator('nav button:has-text("Settings")').click();
5959

6060
// Check for update checker card
@@ -66,7 +66,7 @@ test.describe('Settings', () => {
6666
test('should display current version', async ({ page }) => {
6767
const dashboard = new DashboardPage(page);
6868
await dashboard.navigate();
69-
69+
7070
await page.locator('nav button:has-text("Settings")').click();
7171

7272
// Check current version is displayed
@@ -77,7 +77,7 @@ test.describe('Settings', () => {
7777
test('should have check for updates button', async ({ page }) => {
7878
const dashboard = new DashboardPage(page);
7979
await dashboard.navigate();
80-
80+
8181
await page.locator('nav button:has-text("Settings")').click();
8282

8383
const checkButton = page.getByTestId('check-updates-btn');
@@ -86,10 +86,11 @@ test.describe('Settings', () => {
8686
await expect(checkButton).toBeEnabled();
8787
});
8888

89-
test('should show loading state when checking for updates', async ({ page }) => {
89+
// Skip in web mode - requires Tauri API
90+
test.skip('should show loading state when checking for updates', async ({ page }) => {
9091
const dashboard = new DashboardPage(page);
9192
await dashboard.navigate();
92-
93+
9394
await page.locator('nav button:has-text("Settings")').click();
9495

9596
const checkButton = page.getByTestId('check-updates-btn');
@@ -100,10 +101,11 @@ test.describe('Settings', () => {
100101
await expect(checkButton).toBeDisabled();
101102
});
102103

103-
test('should display update status message', async ({ page }) => {
104+
// Skip in web mode - requires Tauri API
105+
test.skip('should display update status message', async ({ page }) => {
104106
const dashboard = new DashboardPage(page);
105107
await dashboard.navigate();
106-
108+
107109
await page.locator('nav button:has-text("Settings")').click();
108110

109111
const checkButton = page.getByTestId('check-updates-btn');
@@ -117,18 +119,19 @@ test.describe('Settings', () => {
117119
// Verify one of the expected states is shown
118120
const hasMessage = await page.getByTestId('update-message').isVisible().catch(() => false);
119121
const hasUpdate = await page.getByTestId('update-available').isVisible().catch(() => false);
120-
122+
121123
expect(hasMessage || hasUpdate).toBeTruthy();
122124
});
123125

124-
test('should allow multiple update checks', async ({ page }) => {
126+
// Skip in web mode - requires Tauri API
127+
test.skip('should allow multiple update checks', async ({ page }) => {
125128
const dashboard = new DashboardPage(page);
126129
await dashboard.navigate();
127-
130+
128131
await page.locator('nav button:has-text("Settings")').click();
129132

130133
const checkButton = page.getByTestId('check-updates-btn');
131-
134+
132135
// First check
133136
await checkButton.click();
134137
await page.waitForSelector('[data-testid="update-message"], [data-testid="update-available"]', {
@@ -137,18 +140,19 @@ test.describe('Settings', () => {
137140

138141
// Check button should be available again
139142
await expect(checkButton).toBeEnabled();
140-
143+
141144
// Second check
142145
await checkButton.click();
143146
await expect(checkButton).toContainText(/Checking/);
144147
});
145148
});
146149

147150
test.describe('Logs Section', () => {
148-
test('should display logs path', async ({ page }) => {
151+
// Skip in web mode - requires Tauri API
152+
test.skip('should display logs path', async ({ page }) => {
149153
const dashboard = new DashboardPage(page);
150154
await dashboard.navigate();
151-
155+
152156
await page.locator('nav button:has-text("Settings")').click();
153157

154158
const logsPath = page.getByTestId('logs-path');
@@ -160,7 +164,7 @@ test.describe('Settings', () => {
160164
test('should have open logs folder button', async ({ page }) => {
161165
const dashboard = new DashboardPage(page);
162166
await dashboard.navigate();
163-
167+
164168
await page.locator('nav button:has-text("Settings")').click();
165169

166170
const openButton = page.getByTestId('open-logs-btn');
@@ -171,7 +175,7 @@ test.describe('Settings', () => {
171175
test('should show description text', async ({ page }) => {
172176
const dashboard = new DashboardPage(page);
173177
await dashboard.navigate();
174-
178+
175179
await page.locator('nav button:has-text("Settings")').click();
176180

177181
await expect(page.getByText(/Logs are rotated daily/i)).toBeVisible();
@@ -182,7 +186,7 @@ test.describe('Settings', () => {
182186
test('should display all sections in order', async ({ page }) => {
183187
const dashboard = new DashboardPage(page);
184188
await dashboard.navigate();
185-
189+
186190
await page.locator('nav button:has-text("Settings")').click();
187191

188192
// Verify sections appear in expected order
@@ -200,7 +204,7 @@ test.describe('Settings', () => {
200204
test('should be scrollable if content overflows', async ({ page }) => {
201205
const dashboard = new DashboardPage(page);
202206
await dashboard.navigate();
203-
207+
204208
await page.locator('nav button:has-text("Settings")').click();
205209

206210
// Content should be within a scrollable container

0 commit comments

Comments
 (0)