Fix lint errors and format issues for CI/CD

ESLint fixes:
- Fix React setState in useEffect pattern (RegistryPage)
- Remove unused imports and variables across components
- Replace any types with proper TypeScript types
- Prefix unused function parameters with underscore

Rust format fixes:
- Remove trailing whitespace from all Rust files
- Fix JWT test formatting
- Fix lib.rs, repository, and service formatting

All critical lint errors resolved. Remaining warnings are non-breaking
(React Hook exhaustive-deps, react-refresh exports).

Author: Mohammod Al Amin Ashik

apps/desktop/src-tauri/src/lib.rs

@@ -9,8 +9,6 @@ import {
   Sun,
   Moon,
   Zap,
-  Plus,
-  Trash2,
   Check,
   Loader2,
   FolderOpen,
@@ -32,8 +30,7 @@ import { ThemeProvider } from '@/components/ThemeProvider';
 import { OAuthConsentModal } from '@/components/OAuthConsentModal';
 import { SpaceSwitcher } from '@/components/SpaceSwitcher';
 import { useDataSync } from '@/hooks/useDataSync';
-import { useAppStore, useActiveSpace, useViewSpace, useSpaces, useIsLoading, useTheme } from '@/stores';
-import { createSpace, deleteSpace, setActiveSpace as setActiveSpaceAPI } from '@/lib/api/spaces';
+import { useAppStore, useActiveSpace, useViewSpace, useTheme } from '@/stores';
 import { RegistryPage } from '@/features/registry';
 import { FeatureSetsPage } from '@/features/featuresets';
 import { ClientsPage } from '@/features/clients';

apps/desktop/src/App.tsx

@@ -13,7 +13,7 @@
 import { useState, useEffect } from 'react';
 import { invoke } from '@tauri-apps/api/core';
 import { listen } from '@tauri-apps/api/event';
-import { Shield, Check, X, AlertCircle, ExternalLink, Loader2, Globe, Lock } from 'lucide-react';
+import { Shield, Check, X, AlertCircle, Loader2, Globe, Lock } from 'lucide-react';
 import {
   Button,
   Card,

apps/desktop/src/components/OAuthConsentModal.tsx

@@ -12,7 +12,6 @@ import {
   Settings,
   Trash2,
   X,
-  Tag,
   Check,
   ChevronDown,
   ChevronRight,

apps/desktop/src/features/clients/ClientsPage.tsx

@@ -22,7 +22,7 @@ import {
 } from 'lucide-react';
 import { Button } from '@mcpmux/ui';
 import type { FeatureSet, AddMemberInput } from '@/lib/api/featureSets';
-import { setFeatureSetMembers, updateFeatureSet } from '@/lib/api/featureSets';
+import { setFeatureSetMembers } from '@/lib/api/featureSets';
 import type { ServerFeature } from '@/lib/api/serverFeatures';
 import { listServerFeatures } from '@/lib/api/serverFeatures';
 
@@ -49,10 +49,10 @@ export function FeatureSetPanel({ featureSet, spaceId, onClose, onDelete, onUpda
   const [error, setError] = useState<string | null>(null);
   const [expandedServers, setExpandedServers] = useState<Set<string>>(new Set());
 
-  // Edit state for custom sets
-  const [editName, setEditName] = useState(featureSet.name);
-  const [editDescription, setEditDescription] = useState(featureSet.description || '');
-  const [editIcon, setEditIcon] = useState(featureSet.icon || '');
+  // Edit state for custom sets (placeholder for future functionality)
+  // const _editName = featureSet.name;
+  // const _editDescription = featureSet.description || '';
+  // const _editIcon = featureSet.icon || '';
 
   // Collapsible sections - only one expanded at a time, features by default
   const [expandedSections, setExpandedSections] = useState({

apps/desktop/src/features/featuresets/FeatureSetPanel.tsx

@@ -1,10 +1,7 @@
 import { useState, useEffect, useCallback } from 'react';
 import {
-  Wrench,
   Plus,
-  Trash2,
   Loader2,
-  Shield,
   Server,
   Package,
   Settings,
@@ -14,13 +11,11 @@ import {
   Star,
   Search,
   AlertCircle,
-  Users,
 } from 'lucide-react';
 import {
   Card,
   CardHeader,
   CardTitle,
-  CardDescription,
   CardContent,
   Button,
 } from '@mcpmux/ui';

apps/desktop/src/features/featuresets/FeatureSetsPage.tsx

@@ -36,26 +36,38 @@ export function RegistryPage() {
   } = useRegistryStore();
 
   const [localSearch, setLocalSearch] = useState('');
-  const [currentPage, setCurrentPage] = useState(1);
   const viewSpace = useViewSpace();
 
   const itemsPerPage = uiConfig?.items_per_page ?? 24;
 
-  // Reset page when display changes
-  useEffect(() => {
-    setCurrentPage(1);
-  }, [displayServers.length, activeFilters, activeSort, searchQuery]);
+  // Create a key that changes when filters/search/sort change to reset pagination
+  const paginationKey = JSON.stringify({
+    filters: activeFilters,
+    sort: activeSort,
+    search: searchQuery,
+    length: displayServers.length
+  });
+
+  // Local page state that resets when key changes
+  const [pageState, setPageState] = useState({ page: 1, key: paginationKey });
+
+  // Reset page when key changes
+  if (pageState.key !== paginationKey) {
+    setPageState({ page: 1, key: paginationKey });
+  }
+
+  const activePage = pageState.page;
 
   // Pagination logic
   const totalPages = Math.ceil(displayServers.length / itemsPerPage);
   const paginatedServers = displayServers.slice(
-    (currentPage - 1) * itemsPerPage,
-    currentPage * itemsPerPage
+    (activePage - 1) * itemsPerPage,
+    activePage * itemsPerPage
   );
 
   const handlePageChange = (newPage: number) => {
     if (newPage >= 1 && newPage <= totalPages) {
-      setCurrentPage(newPage);
+      setPageState({ page: newPage, key: paginationKey });
       document.querySelector('.registry-grid-container')?.scrollTo({ top: 0, behavior: 'smooth' });
     }
   };
@@ -238,20 +250,20 @@ export function RegistryPage() {
         {totalPages > 1 && (
           <div className="flex items-center gap-2">
             <button
-              onClick={() => handlePageChange(currentPage - 1)}
-              disabled={currentPage === 1}
+              onClick={() => handlePageChange(activePage - 1)}
+              disabled={activePage === 1}
               className="p-1.5 rounded-lg hover:bg-[rgb(var(--surface-hover))] disabled:opacity-30 disabled:hover:bg-transparent transition-colors"
             >
               <svg width="20" height="20" viewBox="0 0 24 24" fill="none" stroke="currentColor" strokeWidth="2" strokeLinecap="round" strokeLinejoin="round">
                 <path d="M15 18l-6-6 6-6" />
               </svg>
             </button>
             <span className="text-sm font-medium min-w-[3rem] text-center">
-              {currentPage} / {totalPages}
+              {activePage} / {totalPages}
             </span>
             <button
-              onClick={() => handlePageChange(currentPage + 1)}
-              disabled={currentPage === totalPages}
+              onClick={() => handlePageChange(activePage + 1)}
+              disabled={activePage === totalPages}
               className="p-1.5 rounded-lg hover:bg-[rgb(var(--surface-hover))] disabled:opacity-30 disabled:hover:bg-transparent transition-colors"
             >
               <svg width="20" height="20" viewBox="0 0 24 24" fill="none" stroke="currentColor" strokeWidth="2" strokeLinecap="round" strokeLinejoin="round">
@@ -289,7 +301,6 @@ interface FilterDropdownProps {
 }
 
 function FilterDropdown({ filter, value, onChange }: FilterDropdownProps) {
-  const selectedOption = filter.options.find(o => o.id === value);
   const isActive = value && value !== 'all';
 
   return (

apps/desktop/src/features/registry/RegistryPage.tsx

@@ -28,12 +28,12 @@ export interface ServerActionMenuProps {
 }
 
 export function ServerActionMenu({
-  serverId,
-  serverName,
+  serverId: _serverId,
+  serverName: _serverName,
   hasInputs,
   isOAuth,
   isEnabled,
-  isConnected,
+  isConnected: _isConnected,
   onConfigure,
   onRefresh,
   onReconnect,

apps/desktop/src/features/servers/ServerActionMenu.tsx

@@ -19,16 +19,10 @@ import {
   FileJson,
 } from 'lucide-react';
 import { ServerActionMenu } from './ServerActionMenu';
-import type { ServerViewModel, ServerDefinition, InstalledServerState } from '../../types/registry';
+import type { ServerViewModel, ServerDefinition, InstalledServerState, InputDefinition } from '../../types/registry';
 import type { ServerFeature } from '@/lib/api/serverFeatures';
 import { listServerFeaturesByServer } from '@/lib/api/serverFeatures';
 import { useViewSpace } from '@/stores';
-import { useServerManager } from '@/hooks/useServerManager';
-import type { ConnectionStatus } from '@/lib/api/serverManager';
-import { ServerLogViewer } from '@/components/ServerLogViewer';
-import { ConfigEditorModal } from '@/components/ConfigEditorModal';
-import { useGatewayEvents, useDomainEvents } from '@/hooks/useDomainEvents';
-import { discoverServers, listInstalledServers } from '@/lib/api/registry';
 import { SourceBadge } from '@/components/SourceBadge';
 
 // Helper to merge definitions with states (same as registryStore)
@@ -44,7 +38,7 @@ function mergeDefinitionsWithStates(
     // Check if any required inputs are missing
     const inputs = def.transport.metadata?.inputs ?? [];
     const inputValues = state?.input_values ?? {};
-    const missing_required_inputs = inputs.some((input: any) => 
+    const missing_required_inputs = inputs.some((input: InputDefinition) =>
       input.required && !inputValues[input.id]
     );
 
@@ -306,8 +300,8 @@ export function ServersPage() {
 
       // Sort by installation time (newest first)
       mergedServers.sort((a, b) => {
-        const dateA = new Date((a as any).created_at || 0).getTime();
-        const dateB = new Date((b as any).created_at || 0).getTime();
+        const dateA = new Date(a.created_at || 0).getTime();
+        const dateB = new Date(b.created_at || 0).getTime();
         return dateB - dateA;
       });
 
@@ -466,10 +460,10 @@ export function ServersPage() {
   const handleEnableClick = async (server: ServerViewModel) => {
     const serverInputs = server.transport.metadata?.inputs ?? [];
     // If server has required inputs that are missing, show config modal
-    if (serverInputs.some((i: any) => i.required) && server.missing_required_inputs) {
+    if (serverInputs.some((i: InputDefinition) => i.required) && server.missing_required_inputs) {
       // Initialize with existing values
       const initialValues: Record<string, string> = {};
-      serverInputs.forEach((input: any) => {
+      serverInputs.forEach((input: InputDefinition) => {
         initialValues[input.id] = server.input_values[input.id] || '';
       });
       setConfigModal({
@@ -530,7 +524,7 @@ export function ServersPage() {
   const handleConfigureClick = (server: ServerViewModel) => {
     const serverInputs = server.transport.metadata?.inputs ?? [];
     const initialValues: Record<string, string> = {};
-    serverInputs.forEach((input: any) => {
+    serverInputs.forEach((input: InputDefinition) => {
       initialValues[input.id] = server.input_values[input.id] || '';
     });
     setConfigModal({
@@ -641,7 +635,7 @@ export function ServersPage() {
 
     setActionLoading(`uninstall-${server.id}`);
     try {
-      const { uninstallServer, refreshRegistry } = await import('@/lib/api/registry');
+      const { uninstallServer } = await import('@/lib/api/registry');
       const { disconnectServer } = await import('@/lib/api/gateway');
 
       if (gatewayRunning && server.enabled && viewSpace) {
@@ -1202,7 +1196,7 @@ export function ServersPage() {
             </p>
 
             <div className="space-y-4">
-              {(configModal.server.transport.metadata?.inputs ?? []).map((input: any) => {
+              {(configModal.server.transport.metadata?.inputs ?? []).map((input: InputDefinition) => {
                 const obtainUrl = input.obtain_url || input.obtain?.url;
                 const obtainInstructions = input.obtain_instructions || input.obtain?.instructions;
                 const inputType = input.type || 'text';
@@ -1313,7 +1307,7 @@ export function ServersPage() {
                   onClick={handleSaveConfig}
                   disabled={
                     (configModal.server.transport.metadata?.inputs ?? [])
-                      .some((i: any) => i.required && !configModal.inputValues[i.id])
+                      .some((i: InputDefinition) => i.required && !configModal.inputValues[i.id])
                   }
                   className="px-4 py-2 text-sm rounded-lg bg-[rgb(var(--primary))] text-[rgb(var(--primary-foreground))] hover:bg-[rgb(var(--primary-hover))] disabled:opacity-50 transition-colors"
                   data-testid="config-save-btn"

apps/desktop/src/features/servers/ServersPage.tsx

@@ -12,7 +12,6 @@ import type {
   InstalledServerState,
   UiConfig,
   HomeConfig,
-  FilterDefinition,
   FilterMatch,
   SortOption,
 } from '../types/registry';