test: remove obsolete client_grants database tests

Migration 003 drops the `client_grants` table and its repository methods
are now no-op shims, so the 6 tests in `tests/database/inbound_client.rs`
that exercised the legacy grant flow had nothing to assert against.
Replaced with a pointer to the new resolver decision-table tests in
`tests/integration/feature_set_resolver.rs`.

Signed-off-by: Mohammod Al Amin Ashik <maa.ashik00@gmail.com>

Author: its-mash

tests/rust/tests/database/inbound_client.rs

@@ -545,239 +545,17 @@ async fn test_revoke_client_tokens() {
 }
 
 // =============================================================================
-// Client Grants Tests (Feature Set Permissions)
+// Client Grants Tests — REMOVED in migration 003.
+//
+// The `client_grants` table and the repository methods that backed it were
+// dropped once the FeatureSetResolver (pin > workspace binding > space-active)
+// became authoritative. The trait methods remain as no-op shims for API
+// compatibility with Tauri commands, but they no longer persist anything.
+//
+// For resolver decision-table tests see
+// `tests/integration/feature_set_resolver.rs`.
 // =============================================================================
 
-#[tokio::test]
-async fn test_grant_feature_set() {
-    let test_db = TestDatabase::new();
-    let db = Arc::new(Mutex::new(test_db.db));
-    let repo = InboundClientRepository::new(Arc::clone(&db));
-    let space_repo = SqliteSpaceRepository::new(db);
-
-    // Create a space (auto-creates All and Default feature sets)
-    let space = fixtures::test_space("Test Space");
-    SpaceRepository::create(&space_repo, &space).await.unwrap();
-
-    let client = create_test_client("Grant Client");
-    repo.save_client(&client).await.unwrap();
-
-    // Grant the auto-created "All" feature set
-    let all_fs_id = format!("fs_all_{}", space.id);
-    repo.grant_feature_set(&client.client_id, &space.id.to_string(), &all_fs_id)
-        .await
-        .expect("Failed to grant");
-
-    // Check grants
-    let grants = repo
-        .get_grants_for_space(&client.client_id, &space.id.to_string())
-        .await
-        .unwrap();
-    assert_eq!(grants.len(), 1);
-    assert!(grants.contains(&all_fs_id));
-}
-
-#[tokio::test]
-async fn test_grant_multiple_feature_sets() {
-    let test_db = TestDatabase::new();
-    let db = Arc::new(Mutex::new(test_db.db));
-    let repo = InboundClientRepository::new(Arc::clone(&db));
-    let space_repo = SqliteSpaceRepository::new(db);
-
-    // Create two spaces
-    let space1 = fixtures::test_space("Space 1");
-    let space2 = fixtures::test_space("Space 2");
-    SpaceRepository::create(&space_repo, &space1).await.unwrap();
-    SpaceRepository::create(&space_repo, &space2).await.unwrap();
-
-    let client = create_test_client("Multi Grant");
-    repo.save_client(&client).await.unwrap();
-
-    // Use auto-created feature set IDs
-    let space1_all = format!("fs_all_{}", space1.id);
-    let space1_default = format!("fs_default_{}", space1.id);
-    let space2_all = format!("fs_all_{}", space2.id);
-
-    repo.grant_feature_set(&client.client_id, &space1.id.to_string(), &space1_all)
-        .await
-        .unwrap();
-    repo.grant_feature_set(&client.client_id, &space1.id.to_string(), &space1_default)
-        .await
-        .unwrap();
-    repo.grant_feature_set(&client.client_id, &space2.id.to_string(), &space2_all)
-        .await
-        .unwrap();
-
-    // Space 1 should have 2
-    let grants1 = repo
-        .get_grants_for_space(&client.client_id, &space1.id.to_string())
-        .await
-        .unwrap();
-    assert_eq!(grants1.len(), 2);
-
-    // Space 2 should have 1
-    let grants2 = repo
-        .get_grants_for_space(&client.client_id, &space2.id.to_string())
-        .await
-        .unwrap();
-    assert_eq!(grants2.len(), 1);
-}
-
-#[tokio::test]
-async fn test_grant_idempotent() {
-    let test_db = TestDatabase::new();
-    let db = Arc::new(Mutex::new(test_db.db));
-    let repo = InboundClientRepository::new(Arc::clone(&db));
-    let space_repo = SqliteSpaceRepository::new(db);
-
-    let space = fixtures::test_space("Test Space");
-    SpaceRepository::create(&space_repo, &space).await.unwrap();
-
-    let client = create_test_client("Idempotent");
-    repo.save_client(&client).await.unwrap();
-
-    let all_fs_id = format!("fs_all_{}", space.id);
-
-    // Grant same thing twice
-    repo.grant_feature_set(&client.client_id, &space.id.to_string(), &all_fs_id)
-        .await
-        .unwrap();
-    repo.grant_feature_set(&client.client_id, &space.id.to_string(), &all_fs_id)
-        .await
-        .unwrap();
-
-    // Should still be 1
-    let grants = repo
-        .get_grants_for_space(&client.client_id, &space.id.to_string())
-        .await
-        .unwrap();
-    assert_eq!(grants.len(), 1);
-}
-
-#[tokio::test]
-async fn test_revoke_feature_set() {
-    let test_db = TestDatabase::new();
-    let db = Arc::new(Mutex::new(test_db.db));
-    let repo = InboundClientRepository::new(Arc::clone(&db));
-    let space_repo = SqliteSpaceRepository::new(db);
-
-    let space = fixtures::test_space("Test Space");
-    SpaceRepository::create(&space_repo, &space).await.unwrap();
-
-    let client = create_test_client("Revoke Grant");
-    repo.save_client(&client).await.unwrap();
-
-    let all_fs_id = format!("fs_all_{}", space.id);
-    let default_fs_id = format!("fs_default_{}", space.id);
-
-    repo.grant_feature_set(&client.client_id, &space.id.to_string(), &all_fs_id)
-        .await
-        .unwrap();
-    repo.grant_feature_set(&client.client_id, &space.id.to_string(), &default_fs_id)
-        .await
-        .unwrap();
-
-    // Revoke one
-    repo.revoke_feature_set(&client.client_id, &space.id.to_string(), &all_fs_id)
-        .await
-        .expect("Failed to revoke");
-
-    // Only default remains
-    let grants = repo
-        .get_grants_for_space(&client.client_id, &space.id.to_string())
-        .await
-        .unwrap();
-    assert_eq!(grants.len(), 1);
-    assert!(grants.contains(&default_fs_id));
-}
-
-#[tokio::test]
-async fn test_get_all_grants() {
-    let test_db = TestDatabase::new();
-    let db = Arc::new(Mutex::new(test_db.db));
-    let repo = InboundClientRepository::new(Arc::clone(&db));
-    let space_repo = SqliteSpaceRepository::new(db);
-
-    let space1 = fixtures::test_space("Space 1");
-    let space2 = fixtures::test_space("Space 2");
-    SpaceRepository::create(&space_repo, &space1).await.unwrap();
-    SpaceRepository::create(&space_repo, &space2).await.unwrap();
-
-    let client = create_test_client("All Grants");
-    repo.save_client(&client).await.unwrap();
-
-    let space1_all = format!("fs_all_{}", space1.id);
-    let space1_default = format!("fs_default_{}", space1.id);
-    let space2_all = format!("fs_all_{}", space2.id);
-
-    repo.grant_feature_set(&client.client_id, &space1.id.to_string(), &space1_all)
-        .await
-        .unwrap();
-    repo.grant_feature_set(&client.client_id, &space1.id.to_string(), &space1_default)
-        .await
-        .unwrap();
-    repo.grant_feature_set(&client.client_id, &space2.id.to_string(), &space2_all)
-        .await
-        .unwrap();
-
-    let all_grants = repo
-        .get_all_grants(&client.client_id)
-        .await
-        .expect("Failed to get all");
-    assert_eq!(all_grants.len(), 2); // 2 spaces
-
-    assert_eq!(all_grants.get(&space1.id.to_string()).unwrap().len(), 2);
-    assert_eq!(all_grants.get(&space2.id.to_string()).unwrap().len(), 1);
-}
-
-#[tokio::test]
-async fn test_grants_per_space_isolation() {
-    let test_db = TestDatabase::new();
-    let db = Arc::new(Mutex::new(test_db.db));
-    let repo = InboundClientRepository::new(Arc::clone(&db));
-    let space_repo = SqliteSpaceRepository::new(db);
-
-    let work = fixtures::test_space("Work");
-    let personal = fixtures::test_space("Personal");
-    SpaceRepository::create(&space_repo, &work).await.unwrap();
-    SpaceRepository::create(&space_repo, &personal)
-        .await
-        .unwrap();
-
-    let client = create_test_client("Space Isolation");
-    repo.save_client(&client).await.unwrap();
-
-    let work_all = format!("fs_all_{}", work.id);
-    let personal_all = format!("fs_all_{}", personal.id);
-
-    // Grant "All" in different spaces
-    repo.grant_feature_set(&client.client_id, &work.id.to_string(), &work_all)
-        .await
-        .unwrap();
-    repo.grant_feature_set(&client.client_id, &personal.id.to_string(), &personal_all)
-        .await
-        .unwrap();
-
-    // Revoke from work only
-    repo.revoke_feature_set(&client.client_id, &work.id.to_string(), &work_all)
-        .await
-        .unwrap();
-
-    // Work should be empty
-    let work_grants = repo
-        .get_grants_for_space(&client.client_id, &work.id.to_string())
-        .await
-        .unwrap();
-    assert!(work_grants.is_empty());
-
-    // Personal still has grant
-    let personal_grants = repo
-        .get_grants_for_space(&client.client_id, &personal.id.to_string())
-        .await
-        .unwrap();
-    assert_eq!(personal_grants.len(), 1);
-}
-
 // =============================================================================
 // Client Settings Update Tests
 // =============================================================================