feat(web-admin): Phase 5 — Dead code cleanup + test coverage

Remove superseded export_config, connect_server, and disconnect_server_v2
apiCall/Tauri paths; extend admin-transport tests for builtins, config-export
routes, direct SSE channels, and dead-command guard.

Signed-off-by: crimsonsunset <jsangio1@gmail.com>

Author: crimsonsunset

apps/desktop/src-tauri/src/commands/gateway.rs

@@ -1619,114 +1619,6 @@ pub async fn generate_gateway_config(
     serde_json::to_string_pretty(&config).map_err(|e| e.to_string())
 }
 
-/// Resolve the system's default space id (the `is_default` Space).
-async fn get_default_space_id(app_state: &AppState) -> Result<String, String> {
-    let space = app_state
-        .space_service
-        .get_default()
-        .await
-        .map_err(|e: anyhow::Error| e.to_string())?
-        .ok_or("No default space found")?;
-    Ok(space.id.to_string())
-}
-
-/// Connect an installed server to the gateway
-#[tauri::command]
-pub async fn connect_server(
-    server_id: String,
-    space_id: Option<String>,
-    app_state: State<'_, AppState>,
-    gateway_state: State<'_, Arc<RwLock<GatewayAppState>>>,
-) -> Result<(), String> {
-    info!("[Gateway] Connecting server: {}", server_id);
-
-    // Get space ID
-    let space_id_str = match space_id {
-        Some(sid) => sid,
-        None => get_default_space_id(&app_state).await?,
-    };
-
-    let space_uuid = Uuid::parse_str(&space_id_str).map_err(|e| e.to_string())?;
-
-    // Get the installed server from the database
-    let installed = app_state
-        .installed_server_repository
-        .get_by_server_id(&space_id_str, &server_id)
-        .await
-        .map_err(|e| {
-            error!(
-                "[Gateway] Failed to get installed server {}: {}",
-                server_id, e
-            );
-            e.to_string()
-        })?
-        .ok_or_else(|| {
-            warn!("[Gateway] Server not installed: {}", server_id);
-            format!("Server not installed: {}", server_id)
-        })?;
-
-    // Use cached definition (offline-first)
-    let server_definition = installed.get_definition().ok_or_else(|| {
-        warn!("[Gateway] Server has no cached definition: {}", server_id);
-        format!("Server has no cached definition: {}", server_id)
-    })?;
-
-    // Get pool service
-    let state = gateway_state.read().await;
-    if !state.running {
-        return Err("Gateway is not running".to_string());
-    }
-    let pool_service = state
-        .pool_service
-        .clone()
-        .ok_or("Pool service not initialized")?;
-    drop(state); // Release lock before async work
-
-    // Build transport config from cached definition + input values
-    let transport = mcpmux_gateway::pool::transport::resolution::build_transport_config(
-        &server_definition.transport,
-        &installed,
-        Some(app_state.data_dir()),
-        mcpmux_gateway::pool::transport::resolution::TransportResolutionOptions::default(),
-    );
-
-    // Connect using pool service (manual connect from API)
-    let ctx = ConnectionContext::new(space_uuid, server_id.clone(), transport);
-    let result = pool_service.connect_server(&ctx).await;
-
-    match result {
-        ConnectionResult::Connected { reused, features } => {
-            info!(
-                "[Gateway] Server {} connected (reused: {}, features: {})",
-                server_id,
-                reused,
-                features.total_count()
-            );
-
-            Ok(())
-        }
-        ConnectionResult::Failed { error } => {
-            error!(
-                "[Gateway] Failed to connect server {}: {}",
-                server_id, error
-            );
-
-            Err(error)
-        }
-        ConnectionResult::OAuthRequired { auth_url } => {
-            warn!(
-                "[Gateway] Server {} requires OAuth authentication",
-                server_id
-            );
-
-            Err(format!(
-                "OAuth required. Please authenticate at: {}",
-                auth_url
-            ))
-        }
-    }
-}
-
 /// Disconnect a server from the gateway
 #[tauri::command]
 pub async fn disconnect_server(

apps/desktop/src-tauri/src/commands/server_manager.rs

@@ -638,82 +638,3 @@ pub async fn logout_server(
 
     Ok(())
 }
-
-/// Disconnect server v2 - Stop connection but keep enabled and preserve all credentials
-///
-/// Preserves: Everything (tokens, DCR, inputs, enabled flag)
-/// Result: State = auth_required (for OAuth) or connecting attempt on next enable
-/// Use case: Temporary pause, quick reconnect possible
-#[tauri::command]
-pub async fn disconnect_server_v2(
-    space_id: String,
-    server_id: String,
-    server_manager_state: State<'_, Arc<RwLock<ServerManagerState>>>,
-    gateway_state: State<'_, Arc<RwLock<crate::commands::gateway::GatewayAppState>>>,
-    app_state: State<'_, AppState>,
-) -> Result<(), String> {
-    use mcpmux_core::AuthConfig;
-
-    let space_uuid = Uuid::parse_str(&space_id).map_err(|e| format!("Invalid space_id: {}", e))?;
-
-    let manager_state = server_manager_state.read().await;
-    let manager = manager_state
-        .manager
-        .as_ref()
-        .ok_or("ServerManager not initialized")?
-        .clone();
-    let pool_service = manager_state
-        .pool_service
-        .as_ref()
-        .ok_or("PoolService not initialized")?
-        .clone();
-    drop(manager_state);
-
-    let key = ServerKey::new(space_uuid, &server_id);
-
-    // 1. Close active connection only
-    pool_service.remove_instance(space_uuid, &server_id);
-
-    // 2. Cancel any pending OAuth flows
-    pool_service
-        .oauth_manager()
-        .cancel_flow_for_space(space_uuid, &server_id);
-
-    // 3. Check if this is an OAuth server (use cached definition)
-    let installed = app_state
-        .installed_server_repository
-        .get_by_server_id(&space_id, &server_id)
-        .await
-        .ok()
-        .flatten();
-    let is_oauth = installed
-        .and_then(|i| i.get_definition())
-        .map(|def| matches!(def.auth, Some(AuthConfig::Oauth)))
-        .unwrap_or(false);
-
-    // 4. Set state based on server type
-    if is_oauth {
-        // OAuth server: go to auth_required (can reconnect with stored tokens)
-        manager.set_auth_required(&key, None).await;
-    } else {
-        // Non-OAuth server: go to disconnected
-        manager.set_disconnected(&key).await;
-    }
-
-    // 5. Mark features unavailable - not connected
-    if let Some(ref feature_service) = gateway_state.read().await.feature_service {
-        if let Err(e) = feature_service
-            .mark_unavailable(&space_id, &server_id)
-            .await
-        {
-            warn!("[ServerManager] Failed to mark features unavailable: {}", e);
-        }
-    }
-
-    info!(
-        "[ServerManager] Server {} disconnected (features unavailable, credentials preserved)",
-        server_id
-    );
-
-    Ok(())
-}

apps/desktop/src-tauri/src/lib.rs

@@ -1023,7 +1023,6 @@ pub fn run() {
             commands::restart_gateway,
             commands::reload_admin_server,
             commands::generate_gateway_config,
-            commands::connect_server,
             commands::disconnect_server,
             commands::list_connected_servers,
             commands::connect_all_enabled_servers,
@@ -1050,7 +1049,6 @@ pub fn run() {
             commands::cancel_auth_v2,
             commands::retry_connection,
             commands::logout_server,
-            commands::disconnect_server_v2,
             // Log commands
             commands::get_server_logs,
             commands::clear_server_logs,

apps/desktop/src/lib/api/gateway.ts

@@ -13,48 +13,13 @@ export interface GatewayStatus {
   connected_backends: number;
 }
 
-/**
- * Public URL advertised by the gateway in OAuth metadata.
- */
-export interface GatewayPublicUrlSettings {
-  configuredPublicBaseUrl: string | null;
-  activePublicBaseUrl: string | null;
-  localBaseUrl: string | null;
-}
-
-/**
- * Config export format.
- */
-export type ExportFormat = 'cursor' | 'vscode' | 'claude';
-
 /**
  * Get gateway status.
  */
 export async function getGatewayStatus(spaceId?: string): Promise<GatewayStatus> {
   return apiCall('get_gateway_status', { spaceId });
 }
 
-/**
- * Get the configured and currently-active public gateway URL settings.
- */
-export async function getGatewayPublicUrlSettings(): Promise<GatewayPublicUrlSettings> {
-  return invoke('get_gateway_public_url_settings');
-}
-
-/**
- * Set the public base URL advertised in OAuth metadata. Pass null to clear it.
- */
-export async function setGatewayPublicBaseUrl(publicBaseUrl: string | null): Promise<void> {
-  return invoke('set_gateway_public_base_url', { publicBaseUrl });
-}
-
-/**
- * Clear the public base URL and return to local-only localhost metadata.
- */
-export async function resetGatewayPublicBaseUrl(): Promise<void> {
-  return invoke('reset_gateway_public_base_url');
-}
-
 /**
  * Probe result for a proposed gateway start.
  *
@@ -151,16 +116,6 @@ export async function restartGateway(opts?: {
   });
 }
 
-/**
- * Export config for a client.
- */
-export async function exportConfig(
-  format: ExportFormat,
-  clientId?: string
-): Promise<string> {
-  return apiCall('export_config', { format, clientId });
-}
-
 /**
  * Backend server status.
  */
@@ -171,13 +126,6 @@ export interface BackendStatus {
   tools_count: number;
 }
 
-/**
- * Connect an installed server to the gateway.
- */
-export async function connectServer(serverId: string): Promise<void> {
-  return apiCall('connect_server', { serverId });
-}
-
 /**
  * Disconnect a server from the gateway.
  * @param serverId - The server ID to disconnect

apps/desktop/src/lib/api/serverManager.ts

@@ -190,20 +190,6 @@ export async function updateServerPackage(spaceId: string, serverId: string): Pr
   return apiCall('update_server_package', { spaceId, serverId });
 }
 
-/**
- * Disconnect server - Stop connection but keep enabled and preserve credentials
- * 
- * Preserves: Everything (tokens, DCR, inputs, enabled flag)
- * Result: State = auth_required (OAuth) or disconnected (non-OAuth)
- * Use case: Temporary pause, quick reconnect possible
- */
-export async function disconnectServerV2(
-  spaceId: string,
-  serverId: string
-): Promise<void> {
-  return apiCall("disconnect_server_v2", { spaceId, serverId });
-}
-
 // ============================================================================
 // Event Listeners (Backend → UI)
 // ============================================================================

scripts/take-screenshots.cjs

@@ -254,7 +254,6 @@ function buildMockHandler() {
         case 'get_pool_stats': return { total_instances: 6, connected_instances: 6, total_space_server_mappings: 6 };
         case 'get_server_logs': return [];
         case 'get_server_log_file': return '/home/user/.local/share/com.mcpmux.desktop/logs';
-        case 'export_config': return '{}';
         case 'init_preset_clients': return null;
         case 'get_logs_path': return '/home/user/.local/share/com.mcpmux.desktop/logs';
         case 'get_startup_settings': return { autoLaunch: true, startMinimized: false, closeToTray: true };