fixes tests

Author: its-mash

tests/e2e/helpers/selectors.ts

@@ -21,21 +21,29 @@ export const byTestId = (testId: string) => $(`[data-testid="${testId}"]`);
  */
 export async function waitForModalClose(timeout = TIMEOUT.short): Promise<void> {
   try {
-    const overlay = await $('.fixed.inset-0.bg-black\\/20');
-    const exists = await overlay.isExisting().catch(() => false);
-    
-    if (!exists) {
-      return; // No modal, nothing to wait for
-    }
-    
-    // Try to wait for it to close naturally
-    const closed = await overlay.waitForDisplayed({ timeout, reverse: true }).then(() => true).catch(() => false);
-    
-    if (!closed) {
-      // Modal still open - try to dismiss it with Escape key
-      console.log('[waitForModalClose] Modal still displayed, trying Escape key');
-      await browser.keys('Escape');
-      await browser.pause(500);
+    // Match any fixed fullscreen overlay (bg-black/20, bg-black/50, bg-black/60)
+    const overlays = await $$('.fixed.inset-0');
+
+    for (const overlay of overlays) {
+      const isDisplayed = await overlay.isDisplayed().catch(() => false);
+      if (!isDisplayed) continue;
+
+      // Check if it looks like a modal backdrop (has bg-black in its classes)
+      const cls = await overlay.getAttribute('class').catch(() => '') ?? '';
+      if (!cls.includes('bg-black')) continue;
+
+      // Try to wait for it to close naturally
+      const closed = await overlay
+        .waitForDisplayed({ timeout, reverse: true })
+        .then(() => true)
+        .catch(() => false);
+
+      if (!closed) {
+        // Modal still open - try to dismiss it with Escape key
+        console.log('[waitForModalClose] Modal still displayed, trying Escape key');
+        await browser.keys('Escape');
+        await browser.pause(500);
+      }
     }
   } catch {
     // Silently continue - modal handling shouldn't fail tests

tests/e2e/specs/deeplink-install.wdio.ts

@@ -214,16 +214,19 @@ describe('Deep Link Install - Valid Server', () => {
 describe('Deep Link Install - Invalid Server', () => {
   it('TC-DL-006: Deep link with unknown server ID shows error', async () => {
     await simulateInstallDeepLink('nonexistent-server-12345');
-    await browser.pause(3000);
+
+    // Wait for the error modal to appear (loading -> error can take time)
+    const errorModal = await byTestId('install-modal-error');
+    const appeared = await errorModal
+      .waitForDisplayed({ timeout: TIMEOUT.long })
+      .then(() => true)
+      .catch(() => false);
 
     await browser.saveScreenshot(
       './tests/e2e/screenshots/dl-06-not-found.png'
     );
 
-    const errorModal = await byTestId('install-modal-error');
-    const isDisplayed = await errorModal.isDisplayed().catch(() => false);
-
-    if (isDisplayed) {
+    if (appeared) {
       // Error message should mention the server was not found
       const errorMsg = await byTestId('install-modal-error-message');
       const text = await errorMsg.getText().catch(() => '');
@@ -235,7 +238,7 @@ describe('Deep Link Install - Invalid Server', () => {
       await browser.pause(1000);
       await waitForModalClose();
     } else {
-      // On slow CI, check page source
+      // Fallback: check page source for error text
       const pageSource = await browser.getPageSource();
       const hasError =
         pageSource.includes('not found') ||

tests/e2e/specs/server-config.wdio.ts

@@ -61,11 +61,11 @@ describe('Server Configuration - PostgreSQL', () => {
   });
 
   it('TC-SC-002b: Enter connection string and save configuration', async () => {
-    const apiKeyInput = await byTestId('config-input-API_KEY');
-    const isInputDisplayed = await apiKeyInput.isDisplayed().catch(() => false);
-    
+    const configInput = await byTestId('config-input-DATABASE_URL');
+    const isInputDisplayed = await configInput.isDisplayed().catch(() => false);
+
     if (isInputDisplayed) {
-      await apiKeyInput.setValue('test_api_key_12345');
+      await configInput.setValue('postgresql://test:test@localhost:5432/testdb');
       await browser.pause(500);
 
       await browser.saveScreenshot('./tests/e2e/screenshots/sc-04-entered-key.png');

tests/e2e/specs/server-lifecycle.wdio.ts

@@ -52,7 +52,7 @@ describe('Server Installation - GitHub Server (No Inputs)', () => {
 
     // Verify GitHub Server is in the list
     const pageSource = await browser.getPageSource();
-    expect(pageSource.includes('GitHub Server')).toBe(true);
+    expect(pageSource.includes('GitHub')).toBe(true);
 
     const enableButton = await byTestId('enable-server-github-server');
     const isEnableDisplayed = await enableButton.isDisplayed().catch(() => false);