updated ci

Author: Mohammod Al Amin Ashik

.github/workflows/ci.yml

@@ -52,8 +52,6 @@ jobs:
     steps:
       - uses: actions/checkout@v4
       - uses: pnpm/action-setup@v4
-        with:
-          version: 9
       - uses: actions/setup-node@v4
         with:
           node-version: 20
@@ -140,8 +138,6 @@ jobs:
         with:
           key: ${{ matrix.target }}-build
       - uses: pnpm/action-setup@v4
-        with:
-          version: 9
       - uses: actions/setup-node@v4
         with:
           node-version: 20
@@ -169,8 +165,6 @@ jobs:
     steps:
       - uses: actions/checkout@v4
       - uses: pnpm/action-setup@v4
-        with:
-          version: 9
       - uses: actions/setup-node@v4
         with:
           node-version: 20
@@ -226,8 +220,6 @@ jobs:
         with:
           key: ${{ matrix.os }}-e2e
       - uses: pnpm/action-setup@v4
-        with:
-          version: 9
       - uses: actions/setup-node@v4
         with:
           node-version: 20

.github/workflows/release.yml

@@ -27,9 +27,6 @@ jobs:
           fetch-depth: 0
 
       - uses: pnpm/action-setup@v4
-        with:
-          version: 9
-
       - uses: actions/setup-node@v4
         with:
           node-version: 20
@@ -85,9 +82,6 @@ jobs:
           key: ${{ matrix.target }}-release
 
       - uses: pnpm/action-setup@v4
-        with:
-          version: 9
-
       - uses: actions/setup-node@v4
         with:
           node-version: 20
@@ -169,9 +163,6 @@ jobs:
           key: ${{ matrix.target }}-nightly
 
       - uses: pnpm/action-setup@v4
-        with:
-          version: 9
-
       - uses: actions/setup-node@v4
         with:
           node-version: 20

apps/desktop/src/features/clients/ClientsPage.tsx

@@ -491,13 +491,13 @@ export default function ClientsPage() {
     : 0;
 
   return (
-    <div className="h-full flex flex-col relative">
+    <div className="h-full flex flex-col relative" data-testid="clients-page">
       {/* Header */}
       <div className="flex-shrink-0 p-8 border-b border-[rgb(var(--border-subtle))]">
         <div className="max-w-[2000px] mx-auto">
           <div className="flex items-center justify-between mb-6">
             <div>
-              <h1 className="text-3xl font-bold">Connected Clients</h1>
+              <h1 className="text-3xl font-bold" data-testid="clients-title">Connected Clients</h1>
               <p className="text-base text-[rgb(var(--muted))] mt-2">
                 Manage OAuth clients and their permissions
               </p>
@@ -573,6 +573,7 @@ export default function ClientsPage() {
                       isSelected ? 'ring-2 ring-primary-500 shadow-lg' : ''
                     }`}
                     onClick={() => openPanel(client)}
+                    data-testid={`client-card-${client.client_id.replace(/[^a-zA-Z0-9-_]/g, '_')}`}
                   >
                     <CardContent className="p-6">
                       {/* Client Header */}

apps/desktop/src/features/featuresets/FeatureSetsPage.tsx

@@ -181,7 +181,7 @@ export function FeatureSetsPage() {
   });
 
   return (
-    <div className="h-full flex flex-col relative">
+    <div className="h-full flex flex-col relative" data-testid="featuresets-page">
       {/* Header */}
       <div className="flex-shrink-0 p-8 border-b border-[rgb(var(--border-subtle))]">
         <div className="max-w-[2000px] mx-auto">
@@ -281,6 +281,7 @@ export function FeatureSetsPage() {
                       isSelected ? 'ring-2 ring-primary-500 shadow-lg' : ''
                     }`}
                     onClick={() => handleOpenPanel(fs)}
+                    data-testid={`featureset-card-${fs.id}`}
                   >
                     <CardContent className="p-6">
                       {/* Header */}

apps/desktop/src/features/spaces/SpacesPage.tsx

@@ -101,7 +101,7 @@ export function SpacesPage() {
   });
 
   return (
-    <div className="h-full flex flex-col relative">
+    <div className="h-full flex flex-col relative" data-testid="spaces-page">
       {/* Header */}
       <div className="flex-shrink-0 p-8 border-b border-[rgb(var(--border-subtle))]">
         <div className="max-w-[2000px] mx-auto">

packages/ui/src/components/layout/Sidebar.tsx

@@ -9,7 +9,7 @@ interface SidebarProps {
 
 export function Sidebar({ children, header, footer }: SidebarProps) {
   return (
-    <nav className="flex h-full flex-col bg-[rgb(var(--surface))]">
+    <nav className="flex h-full flex-col bg-[rgb(var(--surface))]" data-testid="sidebar">
       {header && (
         <div className="flex-shrink-0 p-4 border-b border-[rgb(var(--border-subtle))]">
           {header}

pnpm-lock.yaml

@@ -1,3 +1,4 @@
 packages:
   - 'apps/*'
   - 'packages/*'
+  - 'tests/e2e/mocks/*'

pnpm-workspace.yaml

@@ -0,0 +1,7 @@
+/**
+ * E2E Test Selectors - data-testid only (ADR-003)
+ * Use $('[data-testid="x"]') for all element selection.
+ */
+
+/** Get element by data-testid */
+export const byTestId = (testId: string) => $(`[data-testid="${testId}"]`);