feat(server-clone): Phase 4 — Validation + edge cases

Autonomous decisions:
- PrefixCache reads alias from cached_definition before registry lookup so clone suffix aliases resolve at connect time
- Uninstall-source UX: three-action modal (cancel / source-only / uninstall all) via UninstallSourceWithClonesDialog
- list_clone_dependents filters list_for_space by cloned_from — no new repo method needed

Signed-off-by: crimsonsunset <jsangio1@gmail.com>

Author: crimsonsunset

apps/desktop/src-tauri/src/commands/server_clone.rs

@@ -73,3 +73,21 @@ pub async fn suggest_clone_suffix(
         .await
         .map_err(|e| e.to_string())
 }
+
+/// List installed servers in a space that were cloned from the given source.
+#[tauri::command]
+pub async fn list_clone_dependents(
+    app_service: State<'_, Arc<RwLock<Option<ServerAppService>>>>,
+    space_id: String,
+    source_server_id: String,
+) -> Result<Vec<InstalledServer>, String> {
+    let service_lock = app_service.read().await;
+    let service = service_lock
+        .as_ref()
+        .ok_or("ServerAppService not initialized")?;
+
+    service
+        .list_clone_dependents(&space_id, &source_server_id)
+        .await
+        .map_err(|e| e.to_string())
+}

apps/desktop/src-tauri/src/lib.rs

@@ -873,6 +873,7 @@ pub fn run() {
             commands::clone_server,
             commands::is_clone_id_available,
             commands::suggest_clone_suffix,
+            commands::list_clone_dependents,
             // FeatureSet commands
             commands::list_feature_sets,
             commands::list_feature_sets_by_space,

apps/desktop/src/features/servers/ServersPage.tsx

@@ -22,6 +22,7 @@ import {
 } from 'lucide-react';
 import { ServerActionMenu } from './ServerActionMenu';
 import { CloneAccountModal } from './CloneAccountModal';
+import { UninstallSourceWithClonesDialog } from './UninstallSourceWithClonesDialog';
 import type { ServerViewModel, ServerDefinition, InstalledServerState, InputDefinition } from '../../types/registry';
 import type { ServerFeature } from '@/lib/api/serverFeatures';
 import { listServerFeaturesByServer } from '@/lib/api/serverFeatures';
@@ -38,6 +39,7 @@ import { ConfigEditorModal } from '@/components/ConfigEditorModal';
 import { ServerDefinitionModal } from '@/components/ServerDefinitionModal';
 import { SourceBadge } from '@/components/SourceBadge';
 import type { ClonedInstalledServer } from '@/lib/api/serverClone';
+import { listCloneDependents } from '@/lib/api/serverClone';
 
 /** Server view model extended with optional clone lineage from the backend. */
 type ServerViewModelWithClone = ServerViewModel & { cloned_from?: string };
@@ -220,6 +222,12 @@ export function ServersPage() {
 
   // Clone account wizard state
   const [cloneModalServer, setCloneModalServer] = useState<ServerViewModelWithClone | null>(null);
+
+  // Uninstall source-with-clones confirmation
+  const [uninstallClonesDialog, setUninstallClonesDialog] = useState<{
+    server: ServerViewModelWithClone;
+    dependents: ClonedInstalledServer[];
+  } | null>(null);
 
   // Config editor state
   const [editConfigSpace, setEditConfigSpace] = useState<{ id: string; name: string } | null>(null);
@@ -795,31 +803,103 @@ export function ServersPage() {
     }
   };
 
-  const handleUninstall = async (server: ServerViewModel) => {
+  const performUninstall = async (serverIds: string[]) => {
+    const { uninstallServer } = await import('@/lib/api/registry');
+    const { disconnectServer } = await import('@/lib/api/gateway');
+
+    if (gatewayRunning && viewSpace) {
+      for (const serverId of serverIds) {
+        const target = installedServers.find((entry) => entry.id === serverId);
+        if (!target?.enabled) {
+          continue;
+        }
+
+        try {
+          await disconnectServer(serverId, viewSpace.id);
+        } catch (error) {
+          console.warn(`[ServersPage] Failed to disconnect server from gateway:`, error);
+        }
+      }
+    }
+
+    for (const serverId of serverIds) {
+      await uninstallServer(serverId, viewSpace?.id ?? '');
+    }
+
+    await loadData();
+  };
+
+  const handleUninstall = async (server: ServerViewModelWithClone) => {
+    if (!viewSpace) {
+      return;
+    }
+
+    if (!server.cloned_from) {
+      try {
+        const dependents = await listCloneDependents(viewSpace.id, server.id);
+        if (dependents.length > 0) {
+          setUninstallClonesDialog({ server, dependents });
+          return;
+        }
+      } catch (error) {
+        showToast(String(error), 'error');
+        return;
+      }
+    }
+
     const { getUninstallLabel } = await import('@/components/SourceBadge');
     const actionLabel = getUninstallLabel(server.installation_source);
 
     setActionLoading(`uninstall-${server.id}`);
     try {
-      const { uninstallServer } = await import('@/lib/api/registry');
-      const { disconnectServer } = await import('@/lib/api/gateway');
-      
-      if (gatewayRunning && server.enabled && viewSpace) {
-        try {
-          await disconnectServer(server.id, viewSpace.id);
-        } catch (e) {
-          console.warn(`[ServersPage] Failed to disconnect server from gateway:`, e);
-        }
-      }
-      
-      // ServerAppService handles source-aware cleanup automatically:
-      // - UserConfig: removes from JSON file + DB
-      // - Registry/ManualEntry: just removes from DB
-      await uninstallServer(server.id, viewSpace?.id ?? '');
-      await loadData();
+      await performUninstall([server.id]);
       showToast(`${server.name} ${actionLabel.toLowerCase()}ed`, 'success');
-    } catch (e) {
-      showToast(String(e), 'error');
+    } catch (error) {
+      showToast(String(error), 'error');
+    } finally {
+      setActionLoading(null);
+    }
+  };
+
+  const handleUninstallSourceOnly = async () => {
+    if (!uninstallClonesDialog) {
+      return;
+    }
+
+    const { server } = uninstallClonesDialog;
+    const { getUninstallLabel } = await import('@/components/SourceBadge');
+    const actionLabel = getUninstallLabel(server.installation_source);
+
+    setUninstallClonesDialog(null);
+    setActionLoading(`uninstall-${server.id}`);
+    try {
+      await performUninstall([server.id]);
+      showToast(`${server.name} ${actionLabel.toLowerCase()}ed`, 'success');
+    } catch (error) {
+      showToast(String(error), 'error');
+    } finally {
+      setActionLoading(null);
+    }
+  };
+
+  const handleUninstallAllWithClones = async () => {
+    if (!uninstallClonesDialog) {
+      return;
+    }
+
+    const { server, dependents } = uninstallClonesDialog;
+    const serverIds = [...dependents.map((dependent) => dependent.server_id), server.id];
+
+    setUninstallClonesDialog(null);
+    setActionLoading(`uninstall-${server.id}`);
+    try {
+      await performUninstall(serverIds);
+      showToast(
+        `${server.name} and ${dependents.length} clone${dependents.length === 1 ? '' : 's'} uninstalled`,
+        'success'
+      );
+    } catch (error) {
+      showToast(String(error), 'error');
     } finally {
       setActionLoading(null);
     }
@@ -930,6 +1010,16 @@ export function ServersPage() {
   return (
     <div className="space-y-6" data-testid="servers-page">
       {gatewayControl.ConfirmDialogElement}
+      {uninstallClonesDialog && (
+        <UninstallSourceWithClonesDialog
+          open
+          sourceName={uninstallClonesDialog.server.name}
+          dependents={uninstallClonesDialog.dependents}
+          onCancel={() => setUninstallClonesDialog(null)}
+          onUninstallSourceOnly={handleUninstallSourceOnly}
+          onUninstallAll={handleUninstallAllWithClones}
+        />
+      )}
       {/* Header */}
       <div className="flex items-center justify-between">
         <div>

apps/desktop/src/features/servers/UninstallSourceWithClonesDialog.tsx

@@ -0,0 +1,92 @@
+import { AlertCircle } from 'lucide-react';
+
+export interface CloneDependentSummary {
+  server_id: string;
+  server_name?: string | null;
+}
+
+interface UninstallSourceWithClonesDialogProps {
+  open: boolean;
+  sourceName: string;
+  dependents: CloneDependentSummary[];
+  onCancel: () => void;
+  onUninstallSourceOnly: () => void;
+  onUninstallAll: () => void;
+}
+
+/**
+ * Warn when uninstalling a source server that still has account clones in the same space.
+ */
+export function UninstallSourceWithClonesDialog({
+  open,
+  sourceName,
+  dependents,
+  onCancel,
+  onUninstallSourceOnly,
+  onUninstallAll,
+}: UninstallSourceWithClonesDialogProps) {
+  if (!open) {
+    return null;
+  }
+
+  const dependentLabels = dependents.map(
+    (dependent) => dependent.server_name ?? dependent.server_id
+  );
+  const dependentList = dependentLabels.join(', ');
+  const totalCount = dependents.length + 1;
+
+  return (
+    <div
+      className="fixed inset-0 z-50 flex items-center justify-center bg-black/50 backdrop-blur-sm"
+      onClick={onCancel}
+      data-testid="uninstall-clones-dialog-overlay"
+    >
+      <div
+        className="mx-4 w-full max-w-md rounded-xl border border-[rgb(var(--border))] bg-[rgb(var(--card))] p-6 shadow-xl animate-in fade-in zoom-in-95 duration-200"
+        onClick={(event) => event.stopPropagation()}
+        data-testid="uninstall-clones-dialog"
+      >
+        <div className="mb-4 flex items-start gap-3">
+          <div className="flex-shrink-0 rounded-full bg-amber-500/10 p-2">
+            <AlertCircle className="h-5 w-5 text-amber-500" />
+          </div>
+          <div>
+            <h3 className="text-base font-semibold">Uninstall server with account clones?</h3>
+            <p className="mt-2 text-sm text-[rgb(var(--muted))]">
+              <span className="font-medium text-[rgb(var(--foreground))]">{sourceName}</span> has{' '}
+              {dependents.length} account clone{dependents.length === 1 ? '' : 's'} in this space:{' '}
+              <span className="font-medium text-[rgb(var(--foreground))]">{dependentList}</span>.
+            </p>
+            <p className="mt-2 text-sm text-[rgb(var(--muted))]">
+              Uninstalling the source leaves clones installed and working. You can also remove
+              everything at once.
+            </p>
+          </div>
+        </div>
+        <div className="flex flex-wrap justify-end gap-3">
+          <button
+            onClick={onCancel}
+            className="rounded-lg border border-[rgb(var(--border))] bg-[rgb(var(--surface-active))] px-4 py-2 text-sm font-medium text-[rgb(var(--foreground))] transition-colors hover:bg-[rgb(var(--surface-hover))]"
+            data-testid="uninstall-clones-cancel"
+          >
+            Cancel
+          </button>
+          <button
+            onClick={onUninstallSourceOnly}
+            className="rounded-lg border border-[rgb(var(--border))] bg-[rgb(var(--surface-active))] px-4 py-2 text-sm font-medium text-[rgb(var(--foreground))] transition-colors hover:bg-[rgb(var(--surface-hover))]"
+            data-testid="uninstall-clones-source-only"
+          >
+            Uninstall source only
+          </button>
+          <button
+            onClick={onUninstallAll}
+            className="rounded-lg bg-red-600 px-4 py-2 text-sm font-medium text-white shadow-sm transition-colors hover:bg-red-700"
+            data-testid="uninstall-clones-all"
+          >
+            Uninstall all ({totalCount})
+          </button>
+        </div>
+      </div>
+    </div>
+  );
+}

apps/desktop/src/lib/api/serverClone.ts

@@ -58,6 +58,19 @@ export async function suggestCloneSuffix(
   });
 }
 
+/**
+ * List account clones that were created from the given source server in a space.
+ */
+export async function listCloneDependents(
+  spaceId: string,
+  sourceServerId: string
+): Promise<ClonedInstalledServer[]> {
+  return invoke<ClonedInstalledServer[]>('list_clone_dependents', {
+    spaceId,
+    sourceServerId,
+  });
+}
+
 /**
  * Normalize a server ID the same way the backend does (lowercase, strip underscores/spaces).
  */