fix: harden settings.wdio.ts for slow CI + sanitize malformed JUnit XML

- Add proper app-ready wait in settings.wdio.ts before hook (sidebar
  waitForDisplayed + button waitForClickable), matching the robust
  pattern used by settings-desktop.wdio.ts
- Remove specFileRetries (leaves malformed XML from failed first
  attempts that crashes dorny/test-reporter)
- Add JUnit XML sanitization step in e2e-desktop CI workflow to remove
  files missing <testsuites> before the report job processes them

https://claude.ai/code/session_01N5WUgi8V1zVQBHVw96eVzM
Signed-off-by: Claude <noreply@anthropic.com>

Author: claude

.github/workflows/e2e-desktop.yml

@@ -162,6 +162,20 @@ jobs:
           pattern: e2e-desktop-results-*
           path: test-results
 
+      # Remove malformed/empty JUnit XMLs that crash dorny/test-reporter.
+      # This can happen when tauri-driver crashes mid-spec and the JUnit
+      # reporter writes incomplete XML (missing testsuites or test names).
+      - name: Sanitize JUnit XML reports
+        if: always()
+        run: |
+          for f in test-results/e2e-desktop-results-*/reports/*.xml; do
+            [ -f "$f" ] || continue
+            if ! grep -q '<testsuites' "$f" 2>/dev/null; then
+              echo "Removing malformed JUnit XML: $f"
+              rm "$f"
+            fi
+          done
+
       - name: 'Report: E2E Desktop Tests (Linux)'
         uses: dorny/test-reporter@v2
         if: always()

tests/e2e/specs/settings.wdio.ts

@@ -3,11 +3,17 @@
  * Uses data-testid only (ADR-003).
  */
 
-import { byTestId } from '../helpers/selectors';
+import { byTestId, TIMEOUT } from '../helpers/selectors';
 
 describe('Settings Page', () => {
   before(async () => {
+    // Wait for app to fully load (on CI, app startup can be slower after many prior specs)
+    await browser.pause(3000);
+    const sidebar = await byTestId('sidebar');
+    await sidebar.waitForDisplayed({ timeout: TIMEOUT.veryLong });
+
     const settingsBtn = await byTestId('nav-settings');
+    await settingsBtn.waitForClickable({ timeout: TIMEOUT.medium });
     await settingsBtn.click();
     await browser.pause(2000);
   });

tests/e2e/wdio.conf.ts

@@ -298,10 +298,6 @@ export const config: Options.Testrunner = {
   specs: ['./specs/**/*.wdio.ts'],
   exclude: [],
 
-  // Retry failed spec files once to handle transient CI failures
-  // (e.g., WebKit2GTK driver crashes, timing issues on slow CI runners)
-  specFileRetries: process.env.CI ? 1 : 0,
-
   maxInstances: 1, // Tauri only supports one instance
 
   capabilities: [