Skip to content

Commit ec9acb1

Browse files
committed
feat: wire up HTTP definition headers orthogonally from auth, remove uninstall confirm
- Headers from server definitions are now always applied as default_headers on the reqwest::Client regardless of auth strategy (OAuth, PAT, or no-auth) - If headers contain an Authorization header, OAuth is skipped entirely - If headers have no Authorization, they ride alongside OAuth tokens - Add build_default_headers() and build_http_client() helpers - Remove standalone connect_with_headers() in favor of orthogonal design - Add 19 unit tests for HttpTransport (requires_oauth, header building, connect routing logic, transport_type, description) - Remove broken confirm() dialog from server uninstall action Signed-off-by: Mohammod Al Amin Ashik <maa.ashik00@gmail.com>
1 parent b55b1d2 commit ec9acb1

2 files changed

Lines changed: 559 additions & 33 deletions

File tree

apps/desktop/src/features/servers/ServersPage.tsx

Lines changed: 2 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -709,15 +709,9 @@ export function ServersPage() {
709709
};
710710

711711
const handleUninstall = async (server: ServerViewModel) => {
712-
// Import source-aware helpers
713-
const { getUninstallConfirmMessage, getUninstallLabel } = await import('@/components/SourceBadge');
714-
const confirmMsg = getUninstallConfirmMessage(server.name, server.installation_source);
712+
const { getUninstallLabel } = await import('@/components/SourceBadge');
715713
const actionLabel = getUninstallLabel(server.installation_source);
716-
717-
if (!confirm(confirmMsg)) {
718-
return;
719-
}
720-
714+
721715
setActionLoading(`uninstall-${server.id}`);
722716
try {
723717
const { uninstallServer } = await import('@/lib/api/registry');

0 commit comments

Comments
 (0)