Skip to content

Commit f40fdbb

Browse files
committed
fix(rebase): post-rebase cleanup for settings, schema test, and resolver tests
Drop stale publicUrl draft load after dev-rebased gateway settings split, bump fork reconcile migration expectation to v35, align pinned-header resolver test with deny-by-default Unbound, and fix binding prompt test assertions after panel UI copy change. Signed-off-by: crimsonsunset <jsangio1@gmail.com>
1 parent 947b40c commit f40fdbb

4 files changed

Lines changed: 13 additions & 13 deletions

File tree

apps/desktop/src/features/settings/SettingsPage.tsx

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -210,9 +210,7 @@ export function SettingsPage() {
210210
const s = await getGatewayPortSettings();
211211
setPortSettings(s);
212212
setPortDraft(String(s.configuredPort ?? s.defaultPort));
213-
setPublicUrlDraft(s.publicUrl ?? '');
214213
setPortError(null);
215-
setPublicUrlError(null);
216214
} catch (err) {
217215
console.error('Failed to load gateway port settings:', err);
218216
}

crates/mcpmux-storage/src/database.rs

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -748,7 +748,7 @@ mod tests {
748748
|row| row.get(0),
749749
)
750750
.unwrap();
751-
assert_eq!(version, 34);
751+
assert_eq!(version, 35);
752752

753753
let v16_name: String = db
754754
.conn
@@ -801,7 +801,7 @@ mod tests {
801801
|row| row.get(0),
802802
)
803803
.unwrap();
804-
assert_eq!(version, 34);
804+
assert_eq!(version, 35);
805805

806806
let v16_name: String = db
807807
.conn

tests/rust/tests/integration/feature_set_resolver.rs

Lines changed: 5 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -822,15 +822,14 @@ async fn header_takes_priority_but_reported_roots_still_map_without_one() {
822822
}
823823

824824
#[tokio::test]
825-
async fn pinned_header_root_without_binding_falls_back_to_space_default() {
826-
// A header root for an as-yet-unmapped folder still works out of the box on
827-
// the Space default (upstream emits WorkspaceNeedsBinding so the user can
828-
// attach an explicit mapping).
825+
async fn pinned_header_root_without_binding_is_unbound() {
826+
// A pinned header root with no binding is Tier 1b — deny by default.
827+
// Upstream emits WorkspaceNeedsBinding so the user can attach a mapping.
829828
let f = Fixture::new().await;
830829
f.session_roots.set_pinned("s", test_root());
831830
let r = f.resolver.resolve(Some("s"), None, None).await.unwrap();
832-
assert_eq!(r.source, ResolutionSource::SpaceDefault);
833-
assert_eq!(r.feature_set_ids, vec![f.starter_fs_id.clone()]);
831+
assert_eq!(r.source, ResolutionSource::Unbound);
832+
assert!(r.feature_set_ids.is_empty());
834833
assert_eq!(r.space_id, Some(f.space_id));
835834
}
836835

tests/ts/components/WorkspaceBindingPrompt.test.tsx

Lines changed: 6 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -70,13 +70,16 @@ vi.mock('@/lib/backend/events', () => ({
7070
useWorkspaceEventListener: vi.fn(),
7171
}));
7272

73+
vi.mock('@/hooks/use-viewer-identity.hook', () => ({
74+
useViewerIdentity: () => ({ machineId: null, isLoading: false }),
75+
ViewerIdentityProvider: ({ children }: { children: React.ReactNode }) => children,
76+
}));
77+
7378
import { WorkspaceBindingPanel } from '@/features/workspaces/workspace-binding-panel.component';
7479
import { useBindingPanelStore } from '@/stores/bindingPanelStore';
7580
import { updateWorkspaceBinding, validateWorkspaceRoot } from '@/lib/api/workspaceBindings';
7681
import type { WorkspaceBinding } from '@/lib/api/workspaceBindings';
7782

78-
const PROMPT_COPY = /You just opened this folder in a connected app/i;
79-
8083
const EDIT_BINDING: WorkspaceBinding = {
8184
id: 'b1',
8285
workspace_root: '/home/u/proj',
@@ -144,7 +147,7 @@ describe('WorkspaceBindingPanel – mapping prompt toggle', () => {
144147
renderWithI18n(<WorkspaceBindingPanel />);
145148
await fireNeedsBinding();
146149
expect(await screen.findByTestId('workspace-binding-panel')).toBeTruthy();
147-
expect(await screen.findByText(PROMPT_COPY)).toBeTruthy();
150+
expect(await screen.findByTestId('workspace-binding-no-tools-banner')).toBeTruthy();
148151
});
149152

150153
it('does NOT show the panel when the prompt setting is disabled', async () => {

0 commit comments

Comments
 (0)