fix: resolve flaky Linux E2E desktop tests

Make wdio-video-reporter opt-in (SAVE_ALL_VIDEOS=true) to prevent
screenshot-during-teardown race that causes UND_ERR_SOCKET on Linux
where WebKitGTK tears down synchronously on deleteSession. Also upgrade
E2E workflow to Node 22 so --experimental-strip-types fixtures work
without retry storms.

Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Signed-off-by: Mohammod Al Amin Ashik <maa.ashik00@gmail.com>

Author: its-mash

.github/workflows/e2e-desktop.yml

@@ -54,7 +54,7 @@ jobs:
       - uses: pnpm/action-setup@v4
       - uses: actions/setup-node@v4
         with:
-          node-version: 20
+          node-version: 22
           cache: 'pnpm'
 
       # Cache pnpm store for faster installs

tests/e2e/wdio.conf.ts

@@ -344,11 +344,17 @@ export const config: Options.Testrunner = {
         return `wdio-junit-${options.cid}.xml`;
       },
     }],
-    [video, {
-      saveAllVideos: process.env.SAVE_ALL_VIDEOS === 'true', // Save all videos when env var is set
-      videoSlowdownMultiplier: 1, // Normal speed
-      outputDir: './tests/e2e/videos/',
-    }],
+    // Only enable video reporter when explicitly requested via SAVE_ALL_VIDEOS=true.
+    // The video reporter takes a screenshot after every WebDriver command, including
+    // during session teardown. This races with deleteSession killing the Tauri app,
+    // causing UND_ERR_SOCKET errors that mark passing specs as FAILED.
+    ...(process.env.SAVE_ALL_VIDEOS === 'true'
+      ? [[video, {
+          saveAllVideos: true,
+          videoSlowdownMultiplier: 1,
+          outputDir: './tests/e2e/videos/',
+        }]]
+      : []),
   ],
 
   mochaOpts: {
@@ -490,6 +496,11 @@ export const config: Options.Testrunner = {
   // the next spec's beforeSession to avoid racing with WebdriverIO's own
   // deleteSession call, which would cause cascading failures in subsequent specs.
   afterSession: async function () {
+    // Mark as crashed to prevent afterTest screenshot attempts against a dying session.
+    // On Linux, WebKitGTK tears down the process synchronously on deleteSession,
+    // so any pending screenshot requests will hit a dead socket.
+    tauriDriverCrashed = true;
+
     closeTauriDriver();
 
     // Brief pause to let tauri-driver/mcpmux handle SIGTERM gracefully