From 9f1c331ec97de0736973f17f06f772361e54636e Mon Sep 17 00:00:00 2001 From: Mohammod Al Amin Ashik Date: Thu, 19 Feb 2026 07:22:46 +0800 Subject: [PATCH 1/2] refactor: remove Password and Textarea from InputType enum Password type is redundant - masking is controlled by the `secret` boolean field. Textarea was unused. Updated default-registry.json to use "text" instead of "password" for secret inputs. Signed-off-by: Mohammod Al Amin Ashik --- Cargo.lock | 12 +++++++----- crates/mcpmux-core/src/domain/server.rs | 2 +- .../mcpmux-core/src/registry/default-registry.json | 6 +++--- crates/mcpmux-core/src/registry/types.rs | 4 ---- 4 files changed, 11 insertions(+), 13 deletions(-) diff --git a/Cargo.lock b/Cargo.lock index 0020bed3..10c865d9 100644 --- a/Cargo.lock +++ b/Cargo.lock @@ -2611,7 +2611,7 @@ checksum = "47e1ffaa40ddd1f3ed91f717a33c8c0ee23fff369e3aa8772b9605cc1d22f4c3" [[package]] name = "mcpmux" -version = "0.1.2" +version = "0.2.0" dependencies = [ "anyhow", "async-trait", @@ -2649,7 +2649,7 @@ dependencies = [ [[package]] name = "mcpmux-core" -version = "0.1.2" +version = "0.2.0" dependencies = [ "anyhow", "async-trait", @@ -2674,7 +2674,7 @@ dependencies = [ [[package]] name = "mcpmux-gateway" -version = "0.1.2" +version = "0.2.0" dependencies = [ "anyhow", "async-stream", @@ -2714,7 +2714,7 @@ dependencies = [ [[package]] name = "mcpmux-mcp" -version = "0.1.2" +version = "0.2.0" dependencies = [ "anyhow", "async-trait", @@ -2733,7 +2733,7 @@ dependencies = [ [[package]] name = "mcpmux-storage" -version = "0.1.2" +version = "0.2.0" dependencies = [ "anyhow", "async-trait", @@ -4222,6 +4222,7 @@ dependencies = [ [[package]] name = "rmcp" version = "0.15.0" +source = "git+https://github.com/mcpmux/rust-sdk.git?branch=fix%2Fsse-channel-replacement-conflict#4fd9ae79f3b56d8346097c82ba5b3827f1b9fd21" dependencies = [ "async-trait", "base64 0.22.1", @@ -4255,6 +4256,7 @@ dependencies = [ [[package]] name = "rmcp-macros" version = "0.15.0" +source = "git+https://github.com/mcpmux/rust-sdk.git?branch=fix%2Fsse-channel-replacement-conflict#4fd9ae79f3b56d8346097c82ba5b3827f1b9fd21" dependencies = [ "darling 0.23.0", "proc-macro2", diff --git a/crates/mcpmux-core/src/domain/server.rs b/crates/mcpmux-core/src/domain/server.rs index 02670db6..4f4c3fce 100644 --- a/crates/mcpmux-core/src/domain/server.rs +++ b/crates/mcpmux-core/src/domain/server.rs @@ -140,7 +140,7 @@ pub struct InputDefinition { pub id: String, pub label: String, #[serde(default = "default_input_type")] - pub r#type: String, // "text", "password", etc. + pub r#type: String, // "text", "number", "boolean", "url", etc. Masking controlled by `secret` field. #[serde(default)] pub required: bool, #[serde(default)] diff --git a/crates/mcpmux-core/src/registry/default-registry.json b/crates/mcpmux-core/src/registry/default-registry.json index 700db0a4..3cfa54cf 100644 --- a/crates/mcpmux-core/src/registry/default-registry.json +++ b/crates/mcpmux-core/src/registry/default-registry.json @@ -86,7 +86,7 @@ "id": "GITHUB_PERSONAL_ACCESS_TOKEN", "label": "GitHub Personal Access Token", "description": "A GitHub PAT with appropriate repository access", - "input_type": "password", + "input_type": "text", "required": true, "secret": true, "obtain_url": "https://github.com/settings/tokens", @@ -225,7 +225,7 @@ "id": "BRAVE_API_KEY", "label": "Brave API Key", "description": "Your Brave Search API key", - "input_type": "password", + "input_type": "text", "required": true, "secret": true, "obtain_url": "https://brave.com/search/api/", @@ -267,7 +267,7 @@ "id": "SLACK_BOT_TOKEN", "label": "Slack Bot Token", "description": "Your Slack bot token (xoxb-...)", - "input_type": "password", + "input_type": "text", "required": true, "secret": true, "obtain_url": "https://api.slack.com/apps", diff --git a/crates/mcpmux-core/src/registry/types.rs b/crates/mcpmux-core/src/registry/types.rs index cc0341d7..2df48bce 100644 --- a/crates/mcpmux-core/src/registry/types.rs +++ b/crates/mcpmux-core/src/registry/types.rs @@ -50,10 +50,6 @@ pub enum InputType { /// Single-line text input #[default] Text, - /// Multi-line text input - Textarea, - /// Password/secret input (masked) - Password, /// Boolean toggle Boolean, /// Numeric input From 28efec9d0b7289ad950b86ee1bfd1b4b581185b9 Mon Sep 17 00:00:00 2001 From: Mohammod Al Amin Ashik Date: Thu, 19 Feb 2026 11:29:37 +0800 Subject: [PATCH 2/2] fix: update test to use text input type instead of removed password variant Signed-off-by: Mohammod Al Amin Ashik --- crates/mcpmux-core/src/registry/schema.rs | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/crates/mcpmux-core/src/registry/schema.rs b/crates/mcpmux-core/src/registry/schema.rs index 21c4fac6..c4cddfb5 100644 --- a/crates/mcpmux-core/src/registry/schema.rs +++ b/crates/mcpmux-core/src/registry/schema.rs @@ -339,7 +339,7 @@ mod tests { { "id": "GITHUB_PERSONAL_ACCESS_TOKEN", "label": "GitHub Personal Access Token", - "type": "password", + "type": "text", "required": true, "secret": true, "obtain": {