fix: wire up HTTP definition headers orthogonally from auth - #125
Merged
Conversation
…uninstall confirm - Headers from server definitions are now always applied as default_headers on the reqwest::Client regardless of auth strategy (OAuth, PAT, or no-auth) - If headers contain an Authorization header, OAuth is skipped entirely - If headers have no Authorization, they ride alongside OAuth tokens - Add build_default_headers() and build_http_client() helpers - Remove standalone connect_with_headers() in favor of orthogonal design - Add 19 unit tests for HttpTransport (requires_oauth, header building, connect routing logic, transport_type, description) - Remove broken confirm() dialog from server uninstall action Signed-off-by: Mohammod Al Amin Ashik <maa.ashik00@gmail.com>
its-mash
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
default_headerson thereqwest::Client, regardless of auth strategy (OAuth, PAT, or no-auth)Authorizationheader (e.g., PAT), OAuth is skipped entirelyAuthorization, they ride alongside OAuth tokens on every requestconfirm()dialog from server uninstall action (was executing before user selection)HttpTransportcovering header building, auth routing, and error detectionTest plan
cargo check --workspacepassescargo clippy --workspace -- -D warningscleanhttp.rsall passAuthorization: Bearer <token>header is sent