Add Emad Mac Mini bot setup MCP server - #157
Closed
eibrahim wants to merge 1 commit into
Closed
Conversation
Signed-off-by: Emad Ibrahim <eibrahim@gmail.com>
There was a problem hiding this comment.
Pull request overview
Note
Copilot was unable to run its full agentic suite in this review.
Adds a new default registry entry for Emad Ibrahim’s dedicated Mac mini AI bot setup MCP server and verifies its presence via a unit test.
Changes:
- Added a new server definition to
default-registry.jsonundercom.emadibrahim/dedicated-mac-mini-ai-bot-setup. - Added a test asserting the new server is present and uses HTTP transport with the expected URL/repository.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
| crates/mcpmux-core/src/registry/schema.rs | Adds a unit test to validate the new default-registry entry is present and correctly shaped |
| crates/mcpmux-core/src/registry/default-registry.json | Adds a new default MCP server entry including metadata, links, and HTTP transport |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Comment on lines
+187
to
+188
| "official": true, | ||
| "verified": false |
Comment on lines
+385
to
+390
| match &server.transport { | ||
| TransportConfig::Http { url, .. } => { | ||
| assert_eq!(url, "https://www.emadibrahim.com/mcp"); | ||
| } | ||
| TransportConfig::Stdio { .. } => panic!("expected HTTP transport"), | ||
| } |
Member
|
@eibrahim please contribute to https://github.com/mcpmux/mcp-servers |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Verification