fix(ui): scroll-to + flash the target Settings section on every redirect - #190
Merged
Conversation
Only the Security section highlighted on deep-link; other "open Settings" links dumped the user at the top of the page. Generalize the mechanism so any section can be targeted, and wire the existing redirects to the right one. - SettingsPage: replace the security-only `securityRef`/`flashSecurity` with a section-keyed registry (`registerSection`/`sectionFlashClass`) driven by `pendingSettingsSection`. The matching section scrolls into view + flashes the ring for 2.2s, then the pending value is cleared. Unknown/unmounted sections are dropped (no stale flash). Wrapped the redirect-target sections: Updates, Gateway, Workspaces, Security. - ConnectionCard "Port … change in Settings" → targets the Gateway section. - App update banner "Update now" → targets the Updates section (was top of page). - WorkspaceInstallPanel auth nudge already targets Security — unchanged. Test: App update-banner test now asserts the redirect sets `pendingSettingsSection = 'updates'`. Full TS suite green (224). Claude-Session: https://claude.ai/code/session_01Baan9JmzR43uxxRUh7CAMF Signed-off-by: Mohammod Al Amin Ashik <maa.ashik00@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Follow-up to the Security redirect: make every "open Settings" link land on its specific section and flash it, the way the Security nudge already does. Previously only Security highlighted; other links dropped the user at the top of the page.
Changes
securityRef/flashSecuritywith a generic, section-keyed registry (registerSection+sectionFlashClass) driven bypendingSettingsSection. The matching section scrolls into view + flashes the ring (~2.2s), then the pending value is cleared. Unknown/unmounted sections are dropped so a stale value can't fire later. Wrapped the redirect-target sections: Updates, Gateway, Workspaces, Security. Adding more is a one-line wrap.Test
App update-banner test asserts the redirect sets
pendingSettingsSection = 'updates'. Full TS suite green (224), typecheck clean.Note: cross-tab redirects (Clients/Workspaces/Registry/etc.) already switch to the correct tab; this PR is about in-page Settings-section highlighting. Highlighting a specific row within those other tabs would be a separate change if wanted.
https://claude.ai/code/session_01Baan9JmzR43uxxRUh7CAMF