feat: Streamable HTTP transport with SSE notifications and E2E tests - #61
Merged
Conversation
…otifications Add two layers of test coverage for the Streamable HTTP transport: Rust integration tests (gateway_notifications.rs): - Gateway capabilities advertisement (listChanged: true) - Tools/prompts/resources list_changed forwarding to clients - Server disconnect notification propagation - Grant change notification delivery - Content-based deduplication preventing spurious notifications - Time-based throttling coalescing rapid notifications - Server features refresh triggering notifications - Full re-fetch cycle after notification Tauri E2E tests (streamable-http.wdio.ts): - Gateway Streamable HTTP endpoint serving - Backend HTTP transport connection - Stub server control endpoint verification - All three notification types from backend - Dynamic tool add/remove with notifications - Rapid successive notification handling - Server disable/re-enable reconnection cycle - OAuth DCR registration and approval - PKCE token exchange flow - Authenticated MCP initialize with capabilities check - Session management via Mcp-Session-Id header Supporting infrastructure: - Stub MCP server control endpoints for triggering notifications - E2E helpers for OAuth flow and stub server control - Enhanced transport-level notification tests (prompts, resources) Signed-off-by: Myko <myko@mcpmux.com> Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com> Signed-off-by: Mohammod Al Amin Ashik <maa.ashik00@gmail.com>
![github-code-quality[bot]](https://avatars.githubusercontent.com/u/9919?s=60&v=4){kind=small}
Remove unused imports flagged by code review: - createClient, listClients, listFeatureSetsBySpace, grantFeatureSetToClient from tauri-api - waitForGateway from mcp-client Signed-off-by: Myko <myko@mcpmux.com> Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com> Signed-off-by: Mohammod Al Amin Ashik <maa.ashik00@gmail.com>
Log response status and body before assertions to debug failures. Read response as text first, then parse JSON, so CI output shows the actual error returned by the gateway. Signed-off-by: Myko <myko@mcpmux.com> Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com> Signed-off-by: Mohammod Al Amin Ashik <maa.ashik00@gmail.com>
The gateway returns 406 Not Acceptable when the Accept header doesn't include both application/json and text/event-stream, as required by the MCP Streamable HTTP transport spec (2025-03-26). Add 'Accept: application/json, text/event-stream' to all fetch calls in TC-SH-014 and TC-SH-015 E2E tests. Signed-off-by: Myko <myko@mcpmux.com> Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com> Signed-off-by: Mohammod Al Amin Ashik <maa.ashik00@gmail.com>
Per the MCP Streamable HTTP spec (2025-03-26), when a POST contains JSON-RPC requests, the server may respond with either Content-Type: application/json or text/event-stream. The client MUST support both. Add parseMcpResponse() helper that checks the Content-Type header and extracts JSON from SSE data: lines when the gateway returns an SSE stream instead of plain JSON. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com> Signed-off-by: Mohammod Al Amin Ashik <maa.ashik00@gmail.com>
Three fixes for the SSE notification pipeline: 1. logging_middleware: Skip body.collect() for text/event-stream responses. The middleware was buffering infinite SSE streams, blocking forever and preventing VS Code from receiving any SSE events (notifications, pings). 2. mcp_notifier: Add `force` parameter to notify_all_list_changed(). Grant/feature-set events now bypass content-based hash dedup since the hash is computed from all features in the space and can't detect per-client grant changes that alter effective visibility. 3. Upgrade rmcp to 0.15.0 from fork with SSE channel replacement fix (409 Conflict on duplicate GET streams) and adapt to new struct fields (granted_scopes, Default trait changes). Signed-off-by: Claude Opus 4.6 <noreply@anthropic.com> Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com> Signed-off-by: Mohammod Al Amin Ashik <maa.ashik00@gmail.com>
- Update rmcp to latest commit with comprehensive SSE shadow channel tests (15 tests covering reconnect, dead primary replacement, notification routing, resume paths, and edge cases) - Add last-event-id to non-redacted headers in logging middleware - Fix missing granted_scopes field in credential_store test initializers Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com> Signed-off-by: Mohammod Al Amin Ashik <maa.ashik00@gmail.com>
its-mash
changed the title
The integration test crate pinned rmcp to 0.14.0 while the workspace patch targets 0.15.0, causing CI to use the unpatched crates.io version which lacks the StoredCredentials::granted_scopes field and has incompatible ServerHandler trait bounds. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com> Signed-off-by: Mohammod Al Amin Ashik <maa.ashik00@gmail.com>
Updates rmcp to use 404 Not Found (instead of 401 Unauthorized) for missing/terminated MCP sessions, per MCP spec. This prevents VS Code from triggering full OAuth re-authentication on McpMux restart. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com> Signed-off-by: Mohammod Al Amin Ashik <maa.ashik00@gmail.com>
This was referenced Feb 13, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
McpNotifierlast-event-idtracked for debugging SSE resume behaviorgranted_scopesfield in test initializers forStoredCredentialsNotification test coverage
Rust integration tests (
tests/rust/)streamable_http/notifications.rs(8 tests): Session management,tools/list_changed/prompts/list_changed/resources/list_changeddelivery, multi-client isolation, protocol negotiationstreamable_http/gateway_notifications.rs(9 tests): Gateway-level notification pipeline — capabilities, forwarding, content-based dedup, throttle window, space isolation, server features refreshgateway/stdio_transport.rs: stdio transport integration testsrmcp SDK tests (
rust-sdk/)test_sse_channel_replacement_bug.rs(15 tests): Shadow creation, dead primary replacement, notification routing,Last-Event-IDresume paths, mixed reconnect scenarios, edge casesDesktop E2E tests (
tests/e2e/)streamable-http.wdio.ts(11 test cases TC-SH-001 through TC-SH-015): Full end-to-end notification pipeline through the Tauri desktop app — server lifecycle, tool/prompt/resource list_changed, gateway restart resilienceTest plan
pnpm validate(cargo fmt + clippy + check + eslint + typecheck)🤖 Generated with Claude Code