chore: resolve release-please draft loop and reset versions to v0.0.12 - #90
Merged
Conversation
release-please's `draft: true` config creates draft GitHub releases which don't produce git tags. Since release-please relies on tags for version tracking, it failed to find the previous release and created an infinite loop of release PRs (#78 → #88 → #89). Changes: - Set `draft: false` in release-please-config.json - Add post-release-please step to immediately convert published release to draft via github-script (pre-authenticated octokit, minimal latency) - Set `cancel-in-progress: false` to prevent release builds from being cancelled by subsequent pushes - Reset all version files back to 0.0.12 (last successful release) - Remove bogus v0.0.13/v0.0.14 changelog entries Signed-off-by: Mohammod Al Amin Ashik <maa.ashik00@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
release-please's
draft: trueconfig creates draft GitHub releases which don't produce git tags. Since release-please relies on tags for version tracking, it failed to find the previous release and created an infinite loop of release PRs (#78 → #88 → #89).Changes:
draft: falsein release-please-config.jsoncancel-in-progress: falseto prevent release builds from being cancelled by subsequent pushes