🔒 Exclude .env from Docker context and git - #5
Merged
Conversation
Dockerfile runs COPY . . and Docker does not read .gitignore. This repo takes config via runtime env vars and has no .env today, but nothing prevented one from being created (e.g. for local compose use), committed, or baked into an image layer. Cheap insurance on both fronts.
sl5-guy
self-requested a review
July 20, 2026 16:57
sl5-guy
approved these changes
Jul 20, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Two-line defense-in-depth fix, independent of #4.
DockerfilerunsCOPY . .and Docker does not read.gitignore. This repo currently has no.envusage (config arrives via runtime env vars), so nothing has leaked — but nothing stopped a.envcreated for local convenience from being committed (.gitignoredidn't cover it either) or baked into an image layer permanently.Adds
.env/.env.*to both.dockerignoreand.gitignore.