do not prefer ?? over || with boolean/nullish union - #30
Merged
Conversation
alexlanz
approved these changes
Apr 30, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Configure
ignorePrimitivesforprefer-nullish-coalescingThe
@typescript-eslint/prefer-nullish-coalescingrule is already enabled viastrictTypeChecked.This change adds
ignorePrimitives: { boolean: true }to allow||for boolean union types (boolean | undefined,boolean | null), where||is often the intended operator.For example, with optional React props typed as
boolean | undefined:Using
??here would change the semantics:submitting ?? disabledreturnsfalsewhensubmittingisfalse, while||falls through todisabled. For boolean flags, treatingfalseandundefinedthe same way is typically what you want.The rule still enforces
??for non-boolean nullable types, where falsy coercion is usually a bug:See https://typescript-eslint.io/rules/prefer-nullish-coalescing for reference.