add PostgreSQL preview schema setup and teardown actions - #7
Merged
Conversation
stplasim
marked this pull request as ready for review
February 19, 2026 14:49
alexlanz
approved these changes
Feb 19, 2026
| restartPolicy: Never | ||
| containers: | ||
| - name: prepare-schema-preview | ||
| image: postgres:18 |
Member
There was a problem hiding this comment.
Can we make this configurable with good defaults?
| spec: | ||
| restartPolicy: Never | ||
| containers: | ||
| - name: prepare-schema-preview |
Member
There was a problem hiding this comment.
Suggested change
| - name: prepare-schema-preview | |
| - name: prepare-preview-schema |
I would switch the words since you have it also in other places.
Contributor
Author
|
@alexlanz I made a few more small improvements. Using sed got quite annoying. |
alexlanz
approved these changes
Feb 20, 2026
Comment on lines
+38
to
+45
| envsubst ' | ||
| $JOB_NAME | ||
| $CONFIGMAP_NAME | ||
| $SECRET_NAME | ||
| $PREVIEW_SCHEMA_NAME | ||
| $POSTGRES_IMAGE | ||
| $BASE_SCHEMA | ||
| ' < ${{ github.action_path }}/job-template.yml > job-setup-schema.yml |
Member
There was a problem hiding this comment.
Nice, I did not know this. That is something I will add to my tooling
ThoSap
reviewed
Feb 20, 2026
ThoSap
left a comment
ThoSap
left a comment
Member
There was a problem hiding this comment.
I have nothing to add, very clean refactoring and cleanup of https://github.com/aboutbits/boilerplate-api/pull/177 🔥
Comment on lines
+23
to
+28
| if psql -t -A -c "SELECT 1 FROM information_schema.schemata WHERE schema_name = '${PREVIEW_SCHEMA_NAME}'" | grep -q 1; then | ||
| echo "Schema ${PREVIEW_SCHEMA_NAME} already exists. Skipping setup." | ||
| echo "Script finished successfully!" | ||
| echo "### END $(date --iso-8601=seconds) ###" | ||
| exit 0 | ||
| fi |
Member
There was a problem hiding this comment.
I like that you added this check 💪🏼
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.