add S3 preview setup and teardown actions - #8
Merged
Conversation
stplasim
marked this pull request as ready for review
March 6, 2026 15:58
stplasim
commented
Mar 6, 2026
| restartPolicy: Never | ||
| containers: | ||
| - name: prepare-s3-preview | ||
| image: amazon/aws-cli:2 |
Contributor
Author
There was a problem hiding this comment.
I decided to make this non-configurable, since, in my opinion, it doesn't make much sense to update it independently of the script/CLI.
alexlanz
approved these changes
Mar 6, 2026
| description: 'Name of the ConfigMap' | ||
| required: false | ||
| default: 'app-spring-deployment-environments' | ||
| namespace: |
Member
There was a problem hiding this comment.
I would place the namespace always at top level.
Comment on lines
+14
to
+17
| secret-name: | ||
| description: 'Name of the secret containing credentials' | ||
| required: false | ||
| default: 'app-secrets' |
Member
There was a problem hiding this comment.
I would place this next to the key variables, because the are related.
Comment on lines
+18
to
+33
| s3-bucket-key: | ||
| description: 'Key for S3_BUCKET in ConfigMap' | ||
| required: false | ||
| default: 'S3_BUCKET' | ||
| s3-endpoint-key: | ||
| description: 'Key for S3_ENDPOINT in ConfigMap' | ||
| required: false | ||
| default: 'S3_ENDPOINT' | ||
| s3-region-key: | ||
| description: 'Key for S3_REGION in ConfigMap' | ||
| required: false | ||
| default: 'S3_REGION' | ||
| s3-root-folder-key: | ||
| description: 'Key for S3_ROOT_FOLDER in ConfigMap' | ||
| required: false | ||
| default: 'S3_ROOT_FOLDER' |
Member
There was a problem hiding this comment.
I would place these next to the config map reference, since they are related.
Member
There was a problem hiding this comment.
Same here with the inputs order.
stplasim
force-pushed
the
feat/setup-and-teardown-preview-s3
branch
from
April 20, 2026 06:05
ea04bf2 to
d9f947c
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.