Skip to content

Revert "Update checkstyle.xml" - #4

Merged
SirCotare merged 1 commit into
mainfrom
fix-short-camel-segment-naming
Feb 24, 2025
Merged

Revert "Update checkstyle.xml"#4
SirCotare merged 1 commit into
mainfrom
fix-short-camel-segment-naming

Conversation

@SirCotare

Copy link
Copy Markdown
Member

This reverts commit 4192898.

This change allowed property names to start with a one character long camel-segment. Like uValue. This causes all sorts of problems when converting between cases. Especially mapstruct seems to be unable to find the right getters and setter when converting between classes (getter with get prefix) and records (getter named like the property).

See https://linear.app/aboutbits/issue/FINC-286/fix-naming-issue

@SirCotare SirCotare self-assigned this Feb 24, 2025
@SirCotare
SirCotare merged commit 8cb5985 into main Feb 24, 2025
@SirCotare
SirCotare deleted the fix-short-camel-segment-naming branch February 24, 2025 07:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants