test the ClusterConnectionReconciler error cases

Author: ThoSap

build.gradle.kts

@@ -87,6 +87,7 @@ dependencies {
      * Testing
      */
     testImplementation("io.quarkus:quarkus-junit5")
+    testImplementation("io.quarkus:quarkus-junit5-mockito")
     testImplementation("org.awaitility:awaitility")
     testImplementation(libs.assertj)
     testImplementation(libs.datafaker)
@@ -128,6 +129,13 @@ tasks.withType<Test> {
     systemProperty("java.util.logging.manager", "org.jboss.logmanager.LogManager")
     jvmArgs("--add-opens", "java.base/java.lang=ALL-UNNAMED")
 
+    val mockitoAgent = configurations.testRuntimeClasspath.get().find {
+        it.name.contains("mockito-core")
+    }
+    if (mockitoAgent != null) {
+        jvmArgs("-javaagent:${mockitoAgent.absolutePath}")
+    }
+
     testLogging {
         exceptionFormat = TestExceptionFormat.FULL
 

src/main/java/it/aboutbits/postgresql/core/BaseReconciler.java

@@ -93,19 +93,8 @@ public <E extends Exception> UpdateControl<CR> handleError(
             S status,
             E exception
     ) {
-        return handleError(
-                resource,
-                status,
-                exception.getMessage()
-        );
-    }
-
-    public UpdateControl<CR> handleError(
-            CR resource,
-            S status,
-            @Nullable String message
-    ) {
-        status.setPhase(CRPhase.ERROR).setMessage(message);
+        status.setPhase(CRPhase.ERROR)
+                .setMessage(exception.getMessage());
 
         return UpdateControl.patchStatus(resource)
                 .rescheduleAfter(Duration.ofSeconds(30));

src/main/java/it/aboutbits/postgresql/crd/role/RoleUtil.java

@@ -349,14 +349,14 @@ public static void reconcileRoleMembership(
         }
     }
 
-    public static Query buildGrantRoleToMember(
+    private static Query buildGrantRoleToMember(
             String role,
             String member
     ) {
         return query("grant {0} to {1}", role(role), role(member));
     }
 
-    public static Query buildRevokeRoleFromMember(
+    private static Query buildRevokeRoleFromMember(
             String role,
             String member
     ) {

src/test/java/it/aboutbits/postgresql/crd/connection/ClusterConnectionReconcilerErrorTest.java

@@ -0,0 +1,107 @@
+package it.aboutbits.postgresql.crd.connection;
+
+import io.fabric8.kubernetes.api.model.ObjectMeta;
+import io.javaoperatorsdk.operator.api.reconciler.Context;
+import io.quarkus.test.InjectMock;
+import io.quarkus.test.junit.QuarkusTest;
+import it.aboutbits.postgresql.core.PostgreSQLContextFactory;
+import jakarta.inject.Inject;
+import org.jooq.DSLContext;
+import org.jooq.exception.DataAccessException;
+import org.junit.jupiter.api.BeforeEach;
+import org.junit.jupiter.api.DisplayName;
+import org.junit.jupiter.api.Test;
+
+import java.sql.SQLException;
+import java.util.Collections;
+
+import static org.assertj.core.api.Assertions.assertThat;
+import static org.mockito.ArgumentMatchers.anyString;
+import static org.mockito.Mockito.mock;
+import static org.mockito.Mockito.when;
+
+@QuarkusTest
+class ClusterConnectionReconcilerErrorTest {
+    @InjectMock
+    PostgreSQLContextFactory contextFactory;
+
+    @Inject
+    ClusterConnectionReconciler reconciler;
+
+    private ClusterConnection resource;
+    private Context<ClusterConnection> context;
+
+    @BeforeEach
+    void setUp() {
+        resource = new ClusterConnection();
+
+        var metadata = new ObjectMeta();
+        metadata.setGeneration(1L);
+
+        // We mock the spec to ensure getName() works safely without throwing NPE,
+        // as the custom getName() implementation in ClusterConnection relies on spec fields.
+        var spec = mock(ClusterConnectionSpec.class);
+
+        when(spec.getHost()).thenReturn("localhost");
+        when(spec.getPort()).thenReturn(5432);
+        when(spec.getMaintenanceDatabase()).thenReturn("postgres");
+        when(spec.getParameters()).thenReturn(Collections.emptyMap());
+
+        resource.setSpec(spec);
+        resource.setMetadata(metadata);
+
+        //noinspection unchecked
+        context = mock(Context.class);
+    }
+
+    @Test
+    @DisplayName("Should handle SQLException during DSL context creation")
+    void reconcile_whenDslCreationFails_shouldReturnErrorStatus() throws SQLException {
+        // given
+        var errorMessage = "Connection refused to database";
+
+        when(contextFactory.getDSLContext(resource)).thenThrow(
+                new SQLException(errorMessage)
+        );
+
+        // when
+        var updateControl = reconciler.reconcile(resource, context);
+
+        // then
+        assertThat(updateControl.getResource())
+                .isPresent()
+                .get()
+                .extracting(ClusterConnection::getStatus)
+                .satisfies(status -> {
+                    assertThat(status.getMessage()).contains(errorMessage);
+                });
+    }
+
+    @Test
+    @DisplayName("Should handle DataAccessException during version check")
+    void reconcile_whenVersionQueryFails_shouldReturnErrorStatus() throws SQLException {
+        // given
+        var errorMessage = "Query execution failed";
+        var dslContext = mock(DSLContext.class);
+
+        when(contextFactory.getDSLContext(resource)).thenReturn(
+                dslContext
+        );
+
+        when(dslContext.fetchSingle(anyString())).thenThrow(
+                new DataAccessException(errorMessage)
+        );
+
+        // when
+        var updateControl = reconciler.reconcile(resource, context);
+
+        // then
+        assertThat(updateControl.getResource())
+                .isPresent()
+                .get()
+                .extracting(ClusterConnection::getStatus)
+                .satisfies(status -> {
+                    assertThat(status.getMessage()).contains(errorMessage);
+                });
+    }
+}