AB-449 PostgreSQL Operator: Grant, Database and Schema CRD - #2
Conversation
AB-449 PostgreSQL Operator
Based on the research and PoC done in the ticket and PR https://github.com/aboutbits/minio-operator/pull/1 We most likely will use CloudNativePG AB-396 for the DB Setup and this operator to manage the access, e.g. PostgreSQL roles and grants. The scope of the operator is:
|
…ostgresql-operator-grant-and-db
….name() where possible
6b80a96 to
8d54cfe
Compare
…longer generate the has_*_privilege routines
…adle Plugin 4.4.0
ThoSap
changed the title
Grant and Database CRDGrant, Database and Schema CRD
…Reconciler.java Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
alexlanz
left a comment
alexlanz
left a comment
There was a problem hiding this comment.
It looks really good! I like it.
| } | ||
| } | ||
|
|
||
| // We do not actually delete the database if the reclaimPolicy is set to RETAIN, we only delete the CR instance |
There was a problem hiding this comment.
Does this mean that the SDK has already a logic built in so that I can decide that when I say delete a DB it is acutally not really deleted? That would be nice.
There was a problem hiding this comment.
Yes, that is exactly what my current Cleaner<Database|Schema> interface implementation does.
The cleanup method only removes the CR instance including the PostgreSQL DB/Schema when the reclaimPolicy was set to Delete in the spec, else if it is set to Retain only the CR instance will be deleted but the DB/Schema will be untouched.
If an error happens in the cleanup phase, the cleanup will be retriggered in 60 seconds.
| } | ||
|
|
||
| @Override | ||
| public DeleteControl cleanup( |
There was a problem hiding this comment.
When will this method be called? Currently I don't see any usages.
There was a problem hiding this comment.
This method is internally called by the operator when a CR instance is deleted.
We do not actually need to call this method ourselves, the Operator Framework does that for us.
There was a problem hiding this comment.
Pull request overview
Copilot reviewed 43 out of 62 changed files in this pull request and generated 1 comment.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
…e the spec instead
|
@alexlanz @mmalfertheiner since your last review, I basically just improved the tests, updated NullAway, and implemented your review feedback. From #2 (comment) (see also for the next steps)
I will implement the CRD CEL validation tests for the other existing CRDs in a follow-up PR, else this PR gets way too big. |
No description provided.