Add all icon variants - #13
Merged
Merged
Conversation
Contributor
Author
|
Hi @alexlanz, I push the icons after the review |
added 2 commits
September 6, 2022 12:42
alexlanz
reviewed
Sep 6, 2022
alexlanz
reviewed
Sep 6, 2022
Comment on lines
+101
to
+105
| const iconChunks = new Array( | ||
| Math.ceil(icons.icons.length / DOWNLOAD_CHUNK_SIZE) | ||
| ) | ||
| .fill() | ||
| .map(() => icons.icons.splice(0, DOWNLOAD_CHUNK_SIZE)) |
Member
There was a problem hiding this comment.
Why do you do the split up into multiple chunks? I don't really see any benefit here how you handle it.
Contributor
Author
There was a problem hiding this comment.
I have cleaned it up
alexlanz
reviewed
Sep 6, 2022
alexlanz
approved these changes
Sep 7, 2022
alexlanz
left a comment
alexlanz
left a comment
Member
There was a problem hiding this comment.
Really nice, good job! I like the last refactoring. 🔥
added 2 commits
September 7, 2022 17:00
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR extends the icon generator script to generate all variants of all icons. The script was also improved to handle better the lage amount of icons.
Related ticket