Skip to content

use symbols instead of icons - #26

Merged
lukasvice merged 4 commits into
mainfrom
update-to-symbols
Oct 4, 2024
Merged

use symbols instead of icons#26
lukasvice merged 4 commits into
mainfrom
update-to-symbols

Conversation

@mollpo

@mollpo mollpo commented Sep 3, 2024

Copy link
Copy Markdown
Contributor

No description provided.

@mollpo
mollpo requested a review from alexlanz September 3, 2024 12:08
@mollpo mollpo self-assigned this Sep 3, 2024
@mollpo
mollpo requested a review from lukasvice September 5, 2024 07:05

@lukasvice lukasvice left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Here are my thoughts about this change:

  • Switching from deprecated Google Icons to new Google Symbols is a great improvement!
  • This is a major breaking change, as icon names and sometimes designs are changing.
  • When we update this package in React UI, we'll also need to update the projects where we want to use the new React UI version.
  • I've written some search+replace regexes to migrate to the new icons, but there are a few drawbacks:
    • Some icons might not exist in the new symbols or may have changed names. These will require manual fixes.
    • The old icons were sometimes outlined even when we used the normal (filled) version. The new icons have more filled and outlined versions, which means an icon might change from outlined to filled after migration. To be sure, we have to check each icon manually.

@lukasvice
lukasvice merged commit 5e931ad into main Oct 4, 2024
@lukasvice
lukasvice deleted the update-to-symbols branch October 4, 2024 07:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants