use symbols instead of icons - #26
Merged
Merged
Conversation
lukasvice
reviewed
Oct 3, 2024
lukasvice
left a comment
Member
There was a problem hiding this comment.
Here are my thoughts about this change:
- Switching from deprecated Google Icons to new Google Symbols is a great improvement!
- This is a major breaking change, as icon names and sometimes designs are changing.
- When we update this package in React UI, we'll also need to update the projects where we want to use the new React UI version.
- I've written some search+replace regexes to migrate to the new icons, but there are a few drawbacks:
- Some icons might not exist in the new symbols or may have changed names. These will require manual fixes.
- The old icons were sometimes outlined even when we used the normal (filled) version. The new icons have more filled and outlined versions, which means an icon might change from outlined to filled after migration. To be sure, we have to check each icon manually.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.