Skip to content

Setup Slack Release Monitor App - #1

Merged
stplasim merged 21 commits into
mainfrom
setup-slack-app
May 22, 2026
Merged

Setup Slack Release Monitor App#1
stplasim merged 21 commits into
mainfrom
setup-slack-app

Conversation

@stplasim

Copy link
Copy Markdown
Contributor

No description provided.

@stplasim
stplasim marked this pull request as ready for review May 21, 2026 16:49
Comment thread drizzle.config.ts Outdated
url: process.env.DATABASE_URL!,
},
migrations: {
schema: 'public',

@stplasim stplasim May 22, 2026

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Making the schema configurable is a bit of an issue. I can explain it to you on a call.

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We never use the public schema anymore. Or we hardcode it to main or we need some way to adjust it.

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We can make it configurable, but if we do, it will not be possible to use public because this is a limitation of Drizzle.

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Edit: We cannot make it configurable because it requires code generation to update the schema. I changed it to main and made it possible to configure it in one place.

@alexlanz alexlanz left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Wow, that is really nice! I just left some minor comments

Comment thread tsconfig.json

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Shouldn't we use our ts-config also here or is that not possible?

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This one https://github.com/aboutbits/ts-config?
I totally forgot that we have it. I'll adjust it.

Comment thread readme.md Outdated

A Slack bot that monitors repositories for new releases and posts updates to your channels.

- **Daily digest** - one message per channel per day, grouped by repo

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm thinking more and more if it would not make sense to make a weekly digest, since you have the security check included.

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I saw that using the DIGEST_CRON environment variable it is possible to modify when the digest message gets send. So it is also possible to modify it to weekly (for now only globally, but I think that is enough for starting).

However, since I can add here as a user a custom interval, I would not phrase it "Daily". Can we adjust the wording here? Maybe "Periodic digest"?

Comment thread drizzle.config.ts Outdated
url: process.env.DATABASE_URL!,
},
migrations: {
schema: 'public',

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We never use the public schema anymore. Or we hardcode it to main or we need some way to adjust it.

Comment thread src/index.ts
Comment on lines +17 to +22
const pollCron = Bun.cron(POLL_CRON, async () => {
console.log('Running poll job...')
await runPollJob().catch((err: unknown) => {
console.error('Poll job error:', err)
})
})

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
const pollCron = Bun.cron(POLL_CRON, async () => {
console.log('Running poll job...')
await runPollJob().catch((err: unknown) => {
console.error('Poll job error:', err)
})
})
const pollCron = Bun.cron(POLL_CRON, async () => {
console.log('Poll job - started')
await runPollJob().catch((err: unknown) => {
console.error('Poll job - error:', err)
})
console.log('Poll job - finished')
})

When we log when a job started, then I would log also when the job finishes.

@stplasim
stplasim requested a review from alexlanz May 22, 2026 12:03
@stplasim
stplasim merged commit 07f51da into main May 22, 2026
1 check passed
@stplasim
stplasim deleted the setup-slack-app branch May 22, 2026 13:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants