Setup Slack Release Monitor App - #1
Conversation
| url: process.env.DATABASE_URL!, | ||
| }, | ||
| migrations: { | ||
| schema: 'public', |
There was a problem hiding this comment.
Making the schema configurable is a bit of an issue. I can explain it to you on a call.
There was a problem hiding this comment.
We never use the public schema anymore. Or we hardcode it to main or we need some way to adjust it.
There was a problem hiding this comment.
We can make it configurable, but if we do, it will not be possible to use public because this is a limitation of Drizzle.
There was a problem hiding this comment.
Edit: We cannot make it configurable because it requires code generation to update the schema. I changed it to main and made it possible to configure it in one place.
alexlanz
left a comment
There was a problem hiding this comment.
Wow, that is really nice! I just left some minor comments
There was a problem hiding this comment.
Shouldn't we use our ts-config also here or is that not possible?
There was a problem hiding this comment.
This one https://github.com/aboutbits/ts-config?
I totally forgot that we have it. I'll adjust it.
|
|
||
| A Slack bot that monitors repositories for new releases and posts updates to your channels. | ||
|
|
||
| - **Daily digest** - one message per channel per day, grouped by repo |
There was a problem hiding this comment.
I'm thinking more and more if it would not make sense to make a weekly digest, since you have the security check included.
There was a problem hiding this comment.
I saw that using the DIGEST_CRON environment variable it is possible to modify when the digest message gets send. So it is also possible to modify it to weekly (for now only globally, but I think that is enough for starting).
However, since I can add here as a user a custom interval, I would not phrase it "Daily". Can we adjust the wording here? Maybe "Periodic digest"?
| url: process.env.DATABASE_URL!, | ||
| }, | ||
| migrations: { | ||
| schema: 'public', |
There was a problem hiding this comment.
We never use the public schema anymore. Or we hardcode it to main or we need some way to adjust it.
| const pollCron = Bun.cron(POLL_CRON, async () => { | ||
| console.log('Running poll job...') | ||
| await runPollJob().catch((err: unknown) => { | ||
| console.error('Poll job error:', err) | ||
| }) | ||
| }) |
There was a problem hiding this comment.
| const pollCron = Bun.cron(POLL_CRON, async () => { | |
| console.log('Running poll job...') | |
| await runPollJob().catch((err: unknown) => { | |
| console.error('Poll job error:', err) | |
| }) | |
| }) | |
| const pollCron = Bun.cron(POLL_CRON, async () => { | |
| console.log('Poll job - started') | |
| await runPollJob().catch((err: unknown) => { | |
| console.error('Poll job - error:', err) | |
| }) | |
| console.log('Poll job - finished') | |
| }) |
When we log when a job started, then I would log also when the job finishes.
No description provided.