Skip to content

Sort subscription list alphabetically and normalize repo casing #6

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
stplasim merged 2 commits into from
Jul 27, 2026
Merged

Sort subscription list alphabetically and normalize repo casing #6

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
268f61f
lowercase owner and repo name before insert
stplasim Jul 23, 2026
8bf738e
sort subscribed repo list
stplasim Jul 23, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 5 additions & 1 deletion src/slack/commands/list.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
import { eq } from 'drizzle-orm'
import { eq, sql } from 'drizzle-orm'
import { buildListBlocks } from '@bot/blocks/list'
import { db } from '@db/client'
import { repositories, subscriptions } from '@db/schema'
Expand All @@ -21,6 +21,10 @@ export async function handleList(
.from(subscriptions)
.innerJoin(repositories, eq(subscriptions.repositoryId, repositories.id))
.where(eq(subscriptions.channelId, ctx.channelId))
.orderBy(
sql`lower(${repositories.owner})`,
sql`lower(${repositories.repo})`,
)
Comment on lines +24 to +27

@stplasim stplasim Jul 23, 2026

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just let me know if this is how you want it to be sorted.


if (rows.length === 0) {
await ctx.respond(
Expand Down
7 changes: 7 additions & 0 deletions src/slack/commands/parse.test.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -49,4 +49,11 @@ describe('parseRepo', () => {
test('returns null for empty string', () => {
expect(parseRepo('')).toBeNull()
})

test('lowercases owner and repo', () => {
expect(parseRepo('Torvalds/Linux')).toEqual({
owner: 'torvalds',
name: 'linux',
})
})
})
5 changes: 4 additions & 1 deletion src/slack/commands/parse.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -15,5 +15,8 @@ export function parseRepo(arg: string): { owner: string; name: string } | null {
}

const idx = arg.indexOf('/')
return { owner: arg.slice(0, idx), name: arg.slice(idx + 1) }
return {
owner: arg.slice(0, idx).toLowerCase(),
name: arg.slice(idx + 1).toLowerCase(),
}
}