Feature/init - #2
Merged
Merged
Conversation
mmalfertheiner
requested changes
Jul 21, 2023
mmalfertheiner
left a comment
mmalfertheiner
left a comment
Member
There was a problem hiding this comment.
Very nice job. I added a few questions and a few proposals. Courios to here your thoughts.
|
|
||
| @Builder | ||
| public record EmailParameter( | ||
| @NonNull OffsetDateTime scheduleAt, |
Member
There was a problem hiding this comment.
Are the @NonNull annotation necessary if we already have the package-info?
Member
Author
There was a problem hiding this comment.
I think so, just to be safe
Piiit
requested changes
Jul 21, 2023
Piiit
left a comment
Piiit
left a comment
Member
There was a problem hiding this comment.
Looks very promising, nice work! Have seen that you started some discussions already, so I will add this first review to it and then we continue incrementally...
mmalfertheiner
approved these changes
Oct 17, 2023
mmalfertheiner
left a comment
mmalfertheiner
left a comment
Member
There was a problem hiding this comment.
I just added one more comment. I think we should just give it a try and learn in Aichner.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.