Aic 1195 be improve validation tests - #2
Merged
Conversation
SirCotare
marked this pull request as ready for review
September 9, 2024 10:49
mmalfertheiner
left a comment
mmalfertheiner
left a comment
Member
There was a problem hiding this comment.
I have a few questions, but in general it looks good.
Could you also add a bit of documentation in the readme?
- How to use it?
- How can I build my own rule?
mmalfertheiner
requested changes
Sep 10, 2024
mmalfertheiner
left a comment
mmalfertheiner
left a comment
Member
There was a problem hiding this comment.
The resulting API is very. I would just propose to clean up the value sources a bit.
mmalfertheiner
approved these changes
Sep 11, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.