Ab 237 type ids - #4
Merged
Merged
Conversation
SirCotare
marked this pull request as draft
September 5, 2024 09:27
SirCotare
marked this pull request as ready for review
September 5, 2024 13:30
mmalfertheiner
left a comment
mmalfertheiner
left a comment
Member
There was a problem hiding this comment.
Looks very nice! Well done.
Some thoughts regarding package structure:
Why is jackson and mvc a sub package of type and persistence not? Wouldn't it make sense to also move persistence into type?
By doing so we could also have identity as a direct child package of type.
Wdyt?
type -> jackson, mvc, persistence, identity, ... current classes
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
relevant changes in boilerplate: https://github.com/aboutbits/boilerplate-api/pull/115
This still needs tests and documentation. Those will follow in upcoming PRs.