fix: Claude review - #22
Merged
wayzeek merged 2 commits intoNov 20, 2025
Merged
Conversation
- Add express and @types/express to dependencies for production reliability * Battle-tested error handling and middleware ecosystem * All MCP SDK examples use Express for HTTP transport * Minimal overhead (~50KB) with significant reliability gains - Fix wallet.ts to use viem's documented HDAccount/PrivateKeyAccount types * Use getHdKey() method for extracting private key from mnemonic accounts * Proper type checking instead of unsafe 'as any' casting * Better error messages for debugging - Update bun.lock with express dependencies This ensures all MCP transports (stdio, StreamableHTTP) are production-ready.
Security Fixes: - Add 10mb JSON body size limit to prevent DoS attacks - Validate EVM_ACCOUNT_INDEX to prevent NaN injection - Add HTTP server timeouts (120s request, 65s keepalive) Reliability Fixes: - Implement session cleanup (30min timeout, check every 5min) - Update session timestamps on activity to prevent premature cleanup - Prevent memory leaks from abandoned sessions These changes ensure the server is production-ready and resilient.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.